Fix selectionDirection after setting value of TEXTAREA/INPUT.

Fix selectionDirection after setting value of TEXTAREA/INPUT.

slectionDirection wrongly returned "none" on non-Mac platforms in such
case. This CL

- makes sure that selection operations are done by setSelectionRange().
- moves direction normalization code from setSelectionRangeForBinding() to
  setSelectionRange().

Also, this makes cacheSelection() private. Only HTMLTextFormControlElement calls
it.

BUG=640861
Committed: https://crrev.com/e31411764112e03a39ff3683a4aa8367e950e8d9
Cr-Commit-Position: refs/heads/master@{#414451}

[tkent, 2016-08-25 08:01:04]

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-25 08:01:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tkent, 2016-08-25 08:01:58]

tkent@chromium.org changed reviewers:
+ yosin@chromium.org

[tkent, 2016-08-25 08:01:58]

yosin@, would you review this please?

[yosin_UTC9, 2016-08-25 08:10:22]

lgtm w/ small nit

https://codereview.chromium.org/2277903003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/html/HTMLTextFormControlElement.h (right):

https://codereview.chromium.org/2277903003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/html/HTMLTextFormControlElement.h:137:
m_cachedSelectionStart = start;
nit: Could you add |DCHECK_LE(start, end)|?

[tkent, 2016-08-25 08:16:53]

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-25 08:17:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tkent, 2016-08-25 09:12:40]

https://codereview.chromium.org/2277903003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/html/HTMLTextFormControlElement.h (right):

https://codereview.chromium.org/2277903003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/html/HTMLTextFormControlElement.h:137:
m_cachedSelectionStart = start;
On 2016/08/25 at 08:10:22, Yosi_UTC9 wrote:
> nit: Could you add |DCHECK_LE(start, end)|?

Done.

[tkent, 2016-08-25 09:12:51]

The CQ bit was unchecked by tkent@chromium.org

[tkent, 2016-08-25 10:16:52]

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-25 10:17:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tkent, 2016-08-25 10:21:03]

https://codereview.chromium.org/2277903003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/html/HTMLTextFormControlElement.h (right):

https://codereview.chromium.org/2277903003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/html/HTMLTextFormControlElement.h:137:
m_cachedSelectionStart = start;
On 2016/08/25 at 09:12:40, tkent wrote:
> On 2016/08/25 at 08:10:22, Yosi_UTC9 wrote:
> > nit: Could you add |DCHECK_LE(start, end)|?
> 
> Done.

editing/selection/select-across-readonly-input-1.html and -4.html hit the
DCHECK_LE only on Linux.  I removed the DCHECK_LE, and will investigate later.

[commit-bot: I haz the power, 2016-08-25 11:19:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-25 11:19:11]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[tkent, 2016-08-25 11:38:50]

The CQ bit was checked by tkent@chromium.org

[tkent, 2016-08-25 11:38:51]

The patchset sent to the CQ was uploaded after l-g-t-m from yosin@chromium.org
Link to the patchset: https://codereview.chromium.org/2277903003/#ps40001
(title: "Revert DCHECK_LE")

[commit-bot: I haz the power, 2016-08-25 11:39:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-25 13:55:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-25 13:55:03]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[tkent, 2016-08-25 14:38:56]

The CQ bit was checked by tkent@chromium.org

[commit-bot: I haz the power, 2016-08-25 14:39:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-25 16:22:30]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-25 16:23:45]

Description was changed from

==========
Fix selectionDirection after setting value of TEXTAREA/INPUT.

slectionDirection wrongly returned "none" on non-Mac platforms in such
case. This CL

- makes sure that selection operations are done by setSelectionRange().
- moves direction normalization code from setSelectionRangeForBinding() to
  setSelectionRange().

Also, this makes cacheSelection() private. Only HTMLTextFormControlElement calls
it.

BUG=640861
==========

to

==========
Fix selectionDirection after setting value of TEXTAREA/INPUT.

slectionDirection wrongly returned "none" on non-Mac platforms in such
case. This CL

- makes sure that selection operations are done by setSelectionRange().
- moves direction normalization code from setSelectionRangeForBinding() to
  setSelectionRange().

Also, this makes cacheSelection() private. Only HTMLTextFormControlElement calls
it.

BUG=640861

Committed: https://crrev.com/e31411764112e03a39ff3683a4aa8367e950e8d9
Cr-Commit-Position: refs/heads/master@{#414451}
==========

[commit-bot: I haz the power, 2016-08-25 16:23:46]

Patchset 3 (id:??) landed as
https://crrev.com/e31411764112e03a39ff3683a4aa8367e950e8d9
Cr-Commit-Position: refs/heads/master@{#414451}