third_party/WebKit/Source/core/html/HTMLInputElement.h - Issue 2277903003: Fix selectionDirection after setting value of TEXTAREA/INPUT.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLInputElement.h

Issue 2277903003: Fix selectionDirection after setting value of TEXTAREA/INPUT. (Closed)

Patch Set: Revert DCHECK_LE Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/HTMLInputElement.h

diff --git a/third_party/WebKit/Source/core/html/HTMLInputElement.h b/third_party/WebKit/Source/core/html/HTMLInputElement.h

index fd9bea014b8dd76a2f774a768141f477da7d6ecc..a5633c857e556c87c7ba9ec9e72e73f82cc689ae 100644

--- a/third_party/WebKit/Source/core/html/HTMLInputElement.h

+++ b/third_party/WebKit/Source/core/html/HTMLInputElement.h

@@ -221,8 +221,6 @@ public:

bool needsToUpdateViewValue() const { return m_needsToUpdateViewValue; }

void setInnerEditorValue(const String&) override;

- void cacheSelectionInResponseToSetValue(int caretOffset) { cacheSelection(caretOffset, caretOffset, SelectionHasNoDirection); }

// For test purposes.

void selectColorInColorChooser(const Color&);

void endColorChooser();