Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Side by Side Diff: third_party/WebKit/Source/core/html/HTMLInputElement.h

Issue 2277903003: Fix selectionDirection after setting value of TEXTAREA/INPUT. (Closed)
Patch Set: Revert DCHECK_LE Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2000 Dirk Mueller (mueller@kde.org) 4 * (C) 2000 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004, 2005, 2006, 2007, 2010 Apple Inc. All rights reserved. 5 * Copyright (C) 2004, 2005, 2006, 2007, 2010 Apple Inc. All rights reserved.
6 * Copyright (C) 2012 Samsung Electronics. All rights reserved. 6 * Copyright (C) 2012 Samsung Electronics. All rights reserved.
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Library General Public 9 * modify it under the terms of the GNU Library General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
(...skipping 203 matching lines...) Expand 10 before | Expand all | Expand 10 after
214 HTMLInputElement* checkedRadioButtonForGroup(); 214 HTMLInputElement* checkedRadioButtonForGroup();
215 bool isInRequiredRadioButtonGroup(); 215 bool isInRequiredRadioButtonGroup();
216 216
217 // Functions for InputType classes. 217 // Functions for InputType classes.
218 void setValueInternal(const String&, TextFieldEventBehavior); 218 void setValueInternal(const String&, TextFieldEventBehavior);
219 bool valueAttributeWasUpdatedAfterParsing() const { return m_valueAttributeW asUpdatedAfterParsing; } 219 bool valueAttributeWasUpdatedAfterParsing() const { return m_valueAttributeW asUpdatedAfterParsing; }
220 void updateView(); 220 void updateView();
221 bool needsToUpdateViewValue() const { return m_needsToUpdateViewValue; } 221 bool needsToUpdateViewValue() const { return m_needsToUpdateViewValue; }
222 void setInnerEditorValue(const String&) override; 222 void setInnerEditorValue(const String&) override;
223 223
224 void cacheSelectionInResponseToSetValue(int caretOffset) { cacheSelection(ca retOffset, caretOffset, SelectionHasNoDirection); }
225
226 // For test purposes. 224 // For test purposes.
227 void selectColorInColorChooser(const Color&); 225 void selectColorInColorChooser(const Color&);
228 void endColorChooser(); 226 void endColorChooser();
229 227
230 String defaultToolTip() const override; 228 String defaultToolTip() const override;
231 229
232 static const int maximumLength; 230 static const int maximumLength;
233 231
234 unsigned height() const; 232 unsigned height() const;
235 unsigned width() const; 233 unsigned width() const;
(...skipping 165 matching lines...) Expand 10 before | Expand all | Expand 10 after
401 // The ImageLoader must be owned by this element because the loader code ass umes 399 // The ImageLoader must be owned by this element because the loader code ass umes
402 // that it lives as long as its owning element lives. If we move the loader into 400 // that it lives as long as its owning element lives. If we move the loader into
403 // the ImageInput object we may delete the loader while this element lives o n. 401 // the ImageInput object we may delete the loader while this element lives o n.
404 Member<HTMLImageLoader> m_imageLoader; 402 Member<HTMLImageLoader> m_imageLoader;
405 Member<ListAttributeTargetObserver> m_listAttributeTargetObserver; 403 Member<ListAttributeTargetObserver> m_listAttributeTargetObserver;
406 }; 404 };
407 405
408 } // namespace blink 406 } // namespace blink
409 407
410 #endif // HTMLInputElement_h 408 #endif // HTMLInputElement_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698