third_party/WebKit/Source/core/html/HTMLInputElement.cpp - Issue 2277903003: Fix selectionDirection after setting value of TEXTAREA/INPUT.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLInputElement.cpp

Issue 2277903003: Fix selectionDirection after setting value of TEXTAREA/INPUT. (Closed)

Patch Set: Revert DCHECK_LE Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/HTMLInputElement.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLInputElement.cpp b/third_party/WebKit/Source/core/html/HTMLInputElement.cpp

index 7e77c07556be4a4f9c77343e8c8f2d71818d8586..d34e4b2b72cf6d832910b1a635f1c69c1fbf520d 100644

--- a/third_party/WebKit/Source/core/html/HTMLInputElement.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLInputElement.cpp

@@ -991,11 +991,7 @@ void HTMLInputElement::setEditingValue(const String& value)

subtreeHasChanged();

unsigned max = value.length();

- if (focused())

- setSelectionRange(max, max, SelectionHasNoDirection, NotDispatchSelectEvent);

- else

- cacheSelectionInResponseToSetValue(max);

+ setSelectionRange(max, max, SelectionHasNoDirection, NotDispatchSelectEvent);

dispatchInputEvent();

}