Fix selectionDirection after setting value of TEXTAREA/INPUT.

third_party/WebKit/Source/core/html/HTMLTextFormControlElement.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
  * Copyright (C) 2004, 2005, 2006, 2007 Apple Inc. All rights reserved.
  *           (C) 2006 Alexey Proskuryakov (ap@nypop.com)
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
@@ skipping 252 matching lines @@
     setSelectionRange(newSelectionStart, newSelectionEnd, SelectionHasNoDirection);
 }
 
 void HTMLTextFormControlElement::setSelectionRangeForBinding(int start, int end, const String& directionString)
 {
     TextFieldSelectionDirection direction = SelectionHasNoDirection;
     if (directionString == "forward")
         direction = SelectionHasForwardDirection;
     else if (directionString == "backward")
         direction = SelectionHasBackwardDirection;
-
-    if (direction == SelectionHasNoDirection && document().frame() && document().frame()->editor().behavior().shouldConsiderSelectionAsDirectional())
-        direction = SelectionHasForwardDirection;
-
-    return setSelectionRange(start, end, direction);
+    setSelectionRange(start, end, direction);
 }
 
 static Position positionForIndex(HTMLElement* innerEditor, int index)
 {
     DCHECK_GE(index, 0);
     if (index == 0) {
         Node* node = NodeTraversal::next(*innerEditor, innerEditor);
         if (node && node->isTextNode())
             return Position(node, 0);
         return Position(innerEditor, 0);
@@ skipping 56 matching lines @@
 }
 
 void HTMLTextFormControlElement::setSelectionRange(int start, int end, TextFieldSelectionDirection direction, NeedToDispatchSelectEvent eventBehaviour)
 {
     if (openShadowRoot() || !isTextFormControl())
         return;
     const int editorValueLength = static_cast<int>(innerEditorValue().length());
     DCHECK_GE(editorValueLength, 0);
     end = std::max(std::min(end, editorValueLength), 0);
     start = std::min(std::max(start, 0), end);
+    LocalFrame* frame = document().frame();
+    if (direction == SelectionHasNoDirection && frame && frame->editor().behavior().shouldConsiderSelectionAsDirectional())
+        direction = SelectionHasForwardDirection;
     cacheSelection(start, end, direction);
 
     if (document().focusedElement() != this) {
         if (eventBehaviour == DispatchSelectEvent)
             scheduleSelectEvent();
         return;
     }
 
-    LocalFrame* frame = document().frame();
     HTMLElement* innerEditor = innerEditorElement();
     if (!frame || !innerEditor)
         return;
 
     Position startPosition = positionForIndex(innerEditor, start);
     Position endPosition = start == end ? startPosition : positionForIndex(innerEditor, end);
 
     DCHECK_EQ(start, indexForPosition(innerEditor, startPosition));
     DCHECK_EQ(end, indexForPosition(innerEditor, endPosition));
 
@@ skipping 91 matching lines @@
     case SelectionHasBackwardDirection:
         return backward;
     }
 
     NOTREACHED();
     return none;
 }
 
 const AtomicString& HTMLTextFormControlElement::selectionDirection() const
 {
-    if (!isTextFormControl())
-        return directionString(SelectionHasNoDirection);
+    // Ensured by HTMLInputElement::selectionDirectionForBinding().
+    DCHECK(isTextFormControl());
     if (document().focusedElement() != this)
         return directionString(m_cachedSelectionDirection);
-
     return directionString(computeSelectionDirection());
 }
 
 TextFieldSelectionDirection HTMLTextFormControlElement::computeSelectionDirection() const
 {
     DCHECK(isTextFormControl());
     LocalFrame* frame = document().frame();
     if (!frame)
         return SelectionHasNoDirection;
 
@@ skipping 535 matching lines @@
 }
 
 void HTMLTextFormControlElement::copyNonAttributePropertiesFromElement(const Element& source)
 {
     const HTMLTextFormControlElement& sourceElement = static_cast<const HTMLTextFormControlElement&>(source);
     m_lastChangeWasUserEdit = sourceElement.m_lastChangeWasUserEdit;
     HTMLFormControlElement::copyNonAttributePropertiesFromElement(source);
 }
 
 } // namespace blink