Fix selectionDirection after setting value of TEXTAREA/INPUT.

third_party/WebKit/Source/core/html/HTMLTextFormControlElement.h

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2000 Dirk Mueller (mueller@kde.org)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserved.
  * Copyright (C) 2009, 2010, 2011 Google Inc. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
@@ skipping 97 matching lines @@
     static Position startOfSentence(const Position&);
     static Position endOfSentence(const Position&);
 
 protected:
     HTMLTextFormControlElement(const QualifiedName&, Document&, HTMLFormElement*);
     bool isPlaceholderEmpty() const;
     virtual void updatePlaceholderText() = 0;
 
     void parseAttribute(const QualifiedName&, const AtomicString&, const AtomicString&) override;
 
-    void cacheSelection(int start, int end, TextFieldSelectionDirection direction)
-    {
-        DCHECK_GE(start, 0);
-        m_cachedSelectionStart = start;
-        m_cachedSelectionEnd = end;
-        m_cachedSelectionDirection = direction;
-    }
-
     void restoreCachedSelection();
 
     void defaultEventHandler(Event*) override;
     virtual void subtreeHasChanged() = 0;
 
     void setLastChangeWasNotUserEdit() { m_lastChangeWasUserEdit = false; }
     void addPlaceholderBreakElementIfNecessary();
     String valueWithHardLineBreaks() const;
 
     virtual bool shouldDispatchFormControlChangeEvent(String&, String&);
     void copyNonAttributePropertiesFromElement(const Element&) override;
 
 private:
     int computeSelectionStart() const;
     int computeSelectionEnd() const;
     TextFieldSelectionDirection computeSelectionDirection() const;
+    void cacheSelection(int start, int end, TextFieldSelectionDirection direction)
+    {
+        DCHECK_GE(start, 0);
+        m_cachedSelectionStart = start;

[yosin_UTC9, 2016/08/25 08:10:22]

nit: Could you add |DCHECK_LE(start, end)|?

[tkent, 2016/08/25 09:12:40]

Done.

[tkent, 2016/08/25 10:21:03]

editing/selection/select-across-readonly-input-1.html and -4.html hit the
DCHECK_LE only on Linux.  I removed the DCHECK_LE, and will investigate later.

+        m_cachedSelectionEnd = end;
+        m_cachedSelectionDirection = direction;
+    }
 
     void dispatchFocusEvent(Element* oldFocusedElement, WebFocusType, InputDeviceCapabilities* sourceCapabilities) final;
     void dispatchBlurEvent(Element* newFocusedElement, WebFocusType, InputDeviceCapabilities* sourceCapabilities) final;
     void scheduleSelectEvent();
 
     // Returns true if user-editable value is empty. Used to check placeholder visibility.
     virtual bool isEmptyValue() const = 0;
     // Returns true if suggested value is empty. Used to check placeholder visibility.
     virtual bool isEmptySuggestedValue() const { return true; }
     // Called in dispatchFocusEvent(), after placeholder process, before calling parent's dispatchFocusEvent().
@@ skipping 17 matching lines @@
 }
 
 DEFINE_HTMLELEMENT_TYPE_CASTS_WITH_FUNCTION(HTMLTextFormControlElement);
 
 HTMLTextFormControlElement* enclosingTextFormControl(const Position&);
 HTMLTextFormControlElement* enclosingTextFormControl(Node*);
 
 } // namespace blink
 
 #endif