Add GrVkCopyPipeline to handle vulkan copies as draws

Add GrVkCopyPipeline to handle vulkan copies as draws

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2274663005

Committed: https://skia.googlesource.com/skia/+/bc9b2963bf9e39c47ae5c3ab94b8503b476f4f0e

[egdaniel, 2016-08-25 18:36:43]

Description was changed from

==========
Add GrVkCopyPipeline to handle vulkan copies as draws

BUG=skia:
==========

to

==========
Add GrVkCopyPipeline to handle vulkan copies as draws

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2274663005
==========

[egdaniel, 2016-09-22 16:36:24]

egdaniel@google.com changed reviewers:
+ brianosman@google.com, jvanverth@google.com

[egdaniel, 2016-09-22 16:36:25]

Currently copies as draws will be disabled for all platforms, but this at least
gets the code in there to make it easier to test as various driver fixes come
in.

Please take extra care to look at any synchronization issues in case I missed
something. Most current failures on GPU's seem to be from sync stuff, but as far
as I can tell we are doing thing correctly.

[egdaniel, 2016-09-23 13:44:18]

Patchset #5 (id:80001) has been deleted

[egdaniel, 2016-09-23 18:48:06]

ping

[Brian Osman, 2016-09-25 19:58:48]

As far as I can tell, lgtm.

https://codereview.chromium.org/2274663005/diff/60001/src/gpu/vk/GrVkCopyMana...
File src/gpu/vk/GrVkCopyManager.cpp (right):

https://codereview.chromium.org/2274663005/diff/60001/src/gpu/vk/GrVkCopyMana...
src/gpu/vk/GrVkCopyManager.cpp:44: "vTexCoord = inPosition * uTexCoordXform.xy +
uTexCoordXform.zw;"
nit: indentation

https://codereview.chromium.org/2274663005/diff/60001/src/gpu/vk/GrVkCopyMana...
src/gpu/vk/GrVkCopyManager.cpp:304: vkColorOps,
nit: indentation

https://codereview.chromium.org/2274663005/diff/60001/src/gpu/vk/GrVkCopyMana...
src/gpu/vk/GrVkCopyManager.cpp:309: vkColorOps,
nit: indentation

[egdaniel, 2016-09-26 15:16:49]

https://codereview.chromium.org/2274663005/diff/60001/src/gpu/vk/GrVkCopyMana...
File src/gpu/vk/GrVkCopyManager.cpp (right):

https://codereview.chromium.org/2274663005/diff/60001/src/gpu/vk/GrVkCopyMana...
src/gpu/vk/GrVkCopyManager.cpp:44: "vTexCoord = inPosition * uTexCoordXform.xy +
uTexCoordXform.zw;"
On 2016/09/25 19:58:48, Brian Osman wrote:
> nit: indentation

Done.

https://codereview.chromium.org/2274663005/diff/60001/src/gpu/vk/GrVkCopyMana...
src/gpu/vk/GrVkCopyManager.cpp:304: vkColorOps,
On 2016/09/25 19:58:48, Brian Osman wrote:
> nit: indentation

Done.

https://codereview.chromium.org/2274663005/diff/60001/src/gpu/vk/GrVkCopyMana...
src/gpu/vk/GrVkCopyManager.cpp:309: vkColorOps,
On 2016/09/25 19:58:48, Brian Osman wrote:
> nit: indentation

Done.

[jvanverth1, 2016-09-26 17:26:11]

A couple of questions:

https://codereview.chromium.org/2274663005/diff/60001/src/gpu/vk/GrVkCommandB...
File src/gpu/vk/GrVkCommandBuffer.cpp (right):

https://codereview.chromium.org/2274663005/diff/60001/src/gpu/vk/GrVkCommandB...
src/gpu/vk/GrVkCommandBuffer.cpp:193: void
GrVkCommandBuffer::bindDescriptorSets(const GrVkGpu* gpu,
Just making sure -- is there any way the descriptorSets can be modified before
this command completes on the GPU? (There's a warning about that in the spec.)

https://codereview.chromium.org/2274663005/diff/60001/src/gpu/vk/GrVkGpuComma...
File src/gpu/vk/GrVkGpuCommandBuffer.cpp (right):

https://codereview.chromium.org/2274663005/diff/60001/src/gpu/vk/GrVkGpuComma...
src/gpu/vk/GrVkGpuCommandBuffer.cpp:126: VK_PIPELINE_STAGE_ALL_GRAPHICS_BIT,
Why this change? (just curious)

[egdaniel, 2016-09-26 21:12:39]

https://codereview.chromium.org/2274663005/diff/60001/src/gpu/vk/GrVkCommandB...
File src/gpu/vk/GrVkCommandBuffer.cpp (right):

https://codereview.chromium.org/2274663005/diff/60001/src/gpu/vk/GrVkCommandB...
src/gpu/vk/GrVkCommandBuffer.cpp:193: void
GrVkCommandBuffer::bindDescriptorSets(const GrVkGpu* gpu,
On 2016/09/26 17:26:11, jvanverth1 wrote:
> Just making sure -- is there any way the descriptorSets can be modified before
> this command completes on the GPU? (There's a warning about that in the spec.)

Just in the same way the descriptor sets we bind in the above function call can
be changed. We rely on the resource provider to give us a free descriptor set to
use.

https://codereview.chromium.org/2274663005/diff/60001/src/gpu/vk/GrVkGpuComma...
File src/gpu/vk/GrVkGpuCommandBuffer.cpp (right):

https://codereview.chromium.org/2274663005/diff/60001/src/gpu/vk/GrVkGpuComma...
src/gpu/vk/GrVkGpuCommandBuffer.cpp:126: VK_PIPELINE_STAGE_ALL_GRAPHICS_BIT,
On 2016/09/26 17:26:11, jvanverth1 wrote:
> Why this change? (just curious)

Just from threads about these barriers with other vulkan folk I got the feeling
that TOP/Bottom of pipe weren't really "real" stages and that just using
ALL_GRAPHICS or ALL_STAGES is a safer way to get the results I want (even though
they really should be equivalent).

[jvanverth1, 2016-09-27 13:48:07]

lgtm

[egdaniel, 2016-09-27 14:23:01]

The CQ bit was checked by egdaniel@google.com

[egdaniel, 2016-09-27 14:23:02]

The patchset sent to the CQ was uploaded after l-g-t-m from
brianosman@google.com
Link to the patchset: https://codereview.chromium.org/2274663005/#ps100001
(title: "indent nits")

[commit-bot: I haz the power, 2016-09-27 14:23:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-27 15:00:54]

Description was changed from

==========
Add GrVkCopyPipeline to handle vulkan copies as draws

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2274663005
==========

to

==========
Add GrVkCopyPipeline to handle vulkan copies as draws

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2274663005

Committed:
https://skia.googlesource.com/skia/+/bc9b2963bf9e39c47ae5c3ab94b8503b476f4f0e
==========

[commit-bot: I haz the power, 2016-09-27 15:00:55]

Committed patchset #5 (id:100001) as
https://skia.googlesource.com/skia/+/bc9b2963bf9e39c47ae5c3ab94b8503b476f4f0e