Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(429)

Issue 2363773006: Add command buffer submits before copy calls in vulkan. (Closed)

Created:
4 years, 3 months ago by egdaniel
Modified:
4 years, 2 months ago
Reviewers:
jvanverth1
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : add submits to all copies #

Patch Set 3 : Clean up #

Patch Set 4 : rebase #

Patch Set 5 : rebase #

Patch Set 6 : change submit check to a cap #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -5 lines) Patch
M src/gpu/vk/GrVkCaps.h View 1 2 3 4 5 3 chunks +10 lines, -0 lines 0 comments Download
M src/gpu/vk/GrVkCaps.cpp View 1 2 3 4 5 2 chunks +6 lines, -0 lines 0 comments Download
M src/gpu/vk/GrVkCommandBuffer.h View 2 chunks +4 lines, -0 lines 0 comments Download
M src/gpu/vk/GrVkGpu.cpp View 1 2 3 4 5 3 chunks +12 lines, -0 lines 0 comments Download
M src/gpu/vk/GrVkVaryingHandler.cpp View 1 2 3 4 5 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 21 (13 generated)
egdaniel
I figured we can land this change and see if we see and perf issues ...
4 years, 3 months ago (2016-09-23 18:47:38 UTC) #3
jvanverth1
lgtm
4 years, 2 months ago (2016-09-26 17:35:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2363773006/80001
4 years, 2 months ago (2016-09-27 15:42:38 UTC) #7
commit-bot: I haz the power
Committed patchset #5 (id:80001) as https://skia.googlesource.com/skia/+/25661bac7722860b7589c5b01ec404531d941456
4 years, 2 months ago (2016-09-27 16:03:08 UTC) #9
egdaniel
A revert of this CL (patchset #5 id:80001) has been created in https://codereview.chromium.org/2373503004/ by egdaniel@google.com. ...
4 years, 2 months ago (2016-09-27 17:14:31 UTC) #10
egdaniel
Okay so I fixed this so I'm no longer assuming nvidia == windows
4 years, 2 months ago (2016-09-27 17:34:44 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2363773006/100001
4 years, 2 months ago (2016-09-27 19:11:47 UTC) #19
commit-bot: I haz the power
4 years, 2 months ago (2016-09-27 19:13:08 UTC) #21
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as
https://skia.googlesource.com/skia/+/fd016d7a69f0415f2497d25ec3a7b71de1545826

Powered by Google App Engine
This is Rietveld 408576698