binding: Retires ExceptionState::throwIfNeeded().

binding: Retires ExceptionState::throwIfNeeded().

It's more convenient for call sites to let ExceptionState
throw by default than to explicitly call to throwIfNeeded().

This prevents a mistake that a call site forgets to throw.
ExceptionState now looks a kind of exception scope.

BUG=

Committed: https://crrev.com/652e2642c9a869235108602caf350d88c7ccf7ae
Cr-Commit-Position: refs/heads/master@{#415139}

[Yuki, 2016-08-24 07:27:11]

The CQ bit was checked by yukishiino@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-24 07:27:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-24 07:36:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-24 07:36:11]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Yuki, 2016-08-24 10:12:31]

The CQ bit was checked by yukishiino@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-24 10:12:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Yuki, 2016-08-24 11:43:33]

Description was changed from

==========
binding: Retires ExceptionState::throwIfNeeded().

BUG=
==========

to

==========
binding: Retires ExceptionState::throwIfNeeded().

It's more convenient for call sites to let ExceptionState
throw by default than to explicitly call to throwIfNeeded().

This prevents a mistake that a call site forgets to throw.
ExceptionState now looks a kind of exception scope.

BUG=
==========

[Yuki, 2016-08-24 11:43:53]

yukishiino@chromium.org changed reviewers:
+ haraken@chromium.org

[Yuki, 2016-08-24 11:43:54]

Could you review this CL?

[commit-bot: I haz the power, 2016-08-24 11:58:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-24 11:59:00]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Yuki, 2016-08-24 13:26:19]

The CQ bit was checked by yukishiino@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-24 13:26:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[haraken, 2016-08-24 13:33:02]

Thanks for taking over my CL!

https://codereview.chromium.org/2272613003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/bindings/core/v8/custom/V8DocumentCustom.cpp
(left):

https://codereview.chromium.org/2272613003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/core/v8/custom/V8DocumentCustom.cpp:90: if
(exceptionState.throwIfNeeded())

Don't you need to change this to:

  if (exceptionState.hadException())
    return;

?

Otherwise info.Holder() will be set to the return value when an exception is
thrown.

The same comment for other files in this CL.

[Yuki, 2016-08-24 13:36:20]

https://codereview.chromium.org/2272613003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/bindings/core/v8/custom/V8DocumentCustom.cpp
(left):

https://codereview.chromium.org/2272613003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/core/v8/custom/V8DocumentCustom.cpp:90: if
(exceptionState.throwIfNeeded())
On 2016/08/24 13:33:02, haraken wrote:
> 
> Don't you need to change this to:
> 
>   if (exceptionState.hadException())
>     return;
> 
> ?
> 
> Otherwise info.Holder() will be set to the return value when an exception is
> thrown.
> 
> The same comment for other files in this CL.

Exactly speaking, info.GetReturnValue() will be set to the return value,
however, since an exception will be thrown, user script never observes the
return value.  So practically it's okay.

In general, when an exception is thrown, a return value is just ignored.

[haraken, 2016-08-24 13:45:08]

LGTM

[commit-bot: I haz the power, 2016-08-24 14:27:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-24 14:27:46]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Yuki, 2016-08-25 06:11:55]

The CQ bit was checked by yukishiino@chromium.org

[commit-bot: I haz the power, 2016-08-25 06:12:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-25 07:10:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-25 07:10:02]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Yuki, 2016-08-25 09:26:56]

The CQ bit was checked by yukishiino@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-25 09:27:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-25 10:24:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-25 10:24:52]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Yuki, 2016-08-25 10:27:55]

The CQ bit was checked by yukishiino@chromium.org

[Yuki, 2016-08-25 10:27:56]

The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/2272613003/#ps80001
(title: "Fixed more.  Removing isolate(), etc.")

[commit-bot: I haz the power, 2016-08-25 10:28:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-25 11:58:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-25 11:58:37]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Yuki, 2016-08-25 12:50:41]

The CQ bit was checked by yukishiino@chromium.org

[Yuki, 2016-08-25 12:50:42]

The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/2272613003/#ps100001
(title: "More fix.")

[commit-bot: I haz the power, 2016-08-25 12:51:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-25 14:06:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-25 14:06:36]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Yuki, 2016-08-26 10:13:03]

The CQ bit was checked by yukishiino@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-26 10:13:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-26 12:29:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-26 12:29:14]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Yuki, 2016-08-26 15:28:31]

The CQ bit was checked by yukishiino@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-26 15:28:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-26 18:43:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-26 18:43:10]

Dry run: This issue passed the CQ dry run.

[Yuki, 2016-08-29 03:05:17]

The CQ bit was checked by yukishiino@chromium.org

[Yuki, 2016-08-29 03:05:17]

The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/2272613003/#ps140001
(title: "Synced.")

[commit-bot: I haz the power, 2016-08-29 03:05:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-29 04:34:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-29 04:34:02]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Yuki, 2016-08-29 05:05:35]

The CQ bit was checked by yukishiino@chromium.org

[commit-bot: I haz the power, 2016-08-29 05:06:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-29 05:56:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-29 05:56:29]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Yuki, 2016-08-29 05:59:18]

The CQ bit was checked by yukishiino@chromium.org

[commit-bot: I haz the power, 2016-08-29 05:59:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-29 06:53:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-29 06:53:03]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Yuki, 2016-08-29 06:56:57]

The CQ bit was checked by yukishiino@chromium.org

[Yuki, 2016-08-29 06:56:58]

The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/2272613003/#ps160001
(title: "Synced.")

[commit-bot: I haz the power, 2016-08-29 06:57:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-29 08:09:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-29 08:09:28]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Yuki, 2016-08-29 09:29:51]

The CQ bit was checked by yukishiino@chromium.org

[commit-bot: I haz the power, 2016-08-29 09:30:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-29 10:57:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-29 10:57:03]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Yuki, 2016-08-30 02:27:15]

The CQ bit was checked by yukishiino@chromium.org

[commit-bot: I haz the power, 2016-08-30 02:45:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-30 05:11:50]

Description was changed from

==========
binding: Retires ExceptionState::throwIfNeeded().

It's more convenient for call sites to let ExceptionState
throw by default than to explicitly call to throwIfNeeded().

This prevents a mistake that a call site forgets to throw.
ExceptionState now looks a kind of exception scope.

BUG=
==========

to

==========
binding: Retires ExceptionState::throwIfNeeded().

It's more convenient for call sites to let ExceptionState
throw by default than to explicitly call to throwIfNeeded().

This prevents a mistake that a call site forgets to throw.
ExceptionState now looks a kind of exception scope.

BUG=
==========

[commit-bot: I haz the power, 2016-08-30 05:11:52]

Committed patchset #9 (id:160001)

[commit-bot: I haz the power, 2016-08-30 05:14:23]

Description was changed from

==========
binding: Retires ExceptionState::throwIfNeeded().

It's more convenient for call sites to let ExceptionState
throw by default than to explicitly call to throwIfNeeded().

This prevents a mistake that a call site forgets to throw.
ExceptionState now looks a kind of exception scope.

BUG=
==========

to

==========
binding: Retires ExceptionState::throwIfNeeded().

It's more convenient for call sites to let ExceptionState
throw by default than to explicitly call to throwIfNeeded().

This prevents a mistake that a call site forgets to throw.
ExceptionState now looks a kind of exception scope.

BUG=

Committed: https://crrev.com/652e2642c9a869235108602caf350d88c7ccf7ae
Cr-Commit-Position: refs/heads/master@{#415139}
==========

[commit-bot: I haz the power, 2016-08-30 05:14:28]

Patchset 9 (id:??) landed as
https://crrev.com/652e2642c9a869235108602caf350d88c7ccf7ae
Cr-Commit-Position: refs/heads/master@{#415139}