third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceConstructor4.cpp - Issue 2272613003: binding: Retires ExceptionState::throwIfNeeded().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceConstructor4.cpp

Issue 2272613003: binding: Retires ExceptionState::throwIfNeeded(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Synced. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceConstructor2.cpp ('k') | third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceEventInitConstructor.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceConstructor4.cpp

diff --git a/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceConstructor4.cpp b/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceConstructor4.cpp

index 47ba92051d95f98a0f8141ba147cf1ae3b17cf24..d5c52b9b5f8bb5da2f38cdf8e316358f51d2bd71 100644

--- a/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceConstructor4.cpp

+++ b/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceConstructor4.cpp

@@ -70,7 +70,7 @@ static void constructor2(const v8::FunctionCallbackInfo<v8::Value>& info)

V8StringResource<> usvStringArg;

{

usvStringArg = toUSVString(info.GetIsolate(), info[0], exceptionState);

- if (exceptionState.throwIfNeeded())

+ if (exceptionState.hadException())

return;

}

TestInterfaceConstructor4* impl = TestInterfaceConstructor4::create(usvStringArg);

@@ -95,11 +95,9 @@ static void constructor(const v8::FunctionCallbackInfo<v8::Value>& info)

break;

default:

exceptionState.throwTypeError(ExceptionMessages::notEnoughArguments(1, info.Length()));

- exceptionState.throwIfNeeded();

return;

}

exceptionState.throwTypeError("No matching constructor signature.");

- exceptionState.throwIfNeeded();

}

} // namespace TestInterfaceConstructor4V8Internal