Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(547)

Unified Diff: third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceSecureContext.cpp

Issue 2272613003: binding: Retires ExceptionState::throwIfNeeded(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Synced. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceSecureContext.cpp
diff --git a/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceSecureContext.cpp b/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceSecureContext.cpp
index a47fea5fcef5a811595574bf9b33f3868725a62f..f03f50964e6b3d7fc2ee773ccbb3b09c5088e003 100644
--- a/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceSecureContext.cpp
+++ b/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceSecureContext.cpp
@@ -67,7 +67,6 @@ static void secureContextAttributeAttributeSetter(v8::Local<v8::Value> v8Value,
bool* cppValue = V8bool::toImplWithTypeCheck(info.GetIsolate(), v8Value);
if (!cppValue) {
exceptionState.throwTypeError("The provided value is not of type 'bool'.");
- exceptionState.throwIfNeeded();
return;
}
impl->setSecureContextAttribute(cppValue);
@@ -99,7 +98,6 @@ static void secureContextRuntimeEnabledAttributeAttributeSetter(v8::Local<v8::Va
bool* cppValue = V8bool::toImplWithTypeCheck(info.GetIsolate(), v8Value);
if (!cppValue) {
exceptionState.throwTypeError("The provided value is not of type 'bool'.");
- exceptionState.throwIfNeeded();
return;
}
impl->setSecureContextRuntimeEnabledAttribute(cppValue);
@@ -131,7 +129,6 @@ static void secureContextWindowExposedAttributeAttributeSetter(v8::Local<v8::Val
bool* cppValue = V8bool::toImplWithTypeCheck(info.GetIsolate(), v8Value);
if (!cppValue) {
exceptionState.throwTypeError("The provided value is not of type 'bool'.");
- exceptionState.throwIfNeeded();
return;
}
impl->setSecureContextWindowExposedAttribute(cppValue);
@@ -163,7 +160,6 @@ static void secureContextWorkerExposedAttributeAttributeSetter(v8::Local<v8::Val
bool* cppValue = V8bool::toImplWithTypeCheck(info.GetIsolate(), v8Value);
if (!cppValue) {
exceptionState.throwTypeError("The provided value is not of type 'bool'.");
- exceptionState.throwIfNeeded();
return;
}
impl->setSecureContextWorkerExposedAttribute(cppValue);
@@ -195,7 +191,6 @@ static void secureContextWindowExposedRuntimeEnabledAttributeAttributeSetter(v8:
bool* cppValue = V8bool::toImplWithTypeCheck(info.GetIsolate(), v8Value);
if (!cppValue) {
exceptionState.throwTypeError("The provided value is not of type 'bool'.");
- exceptionState.throwIfNeeded();
return;
}
impl->setSecureContextWindowExposedRuntimeEnabledAttribute(cppValue);
@@ -227,7 +222,6 @@ static void secureContextWorkerExposedRuntimeEnabledAttributeAttributeSetter(v8:
bool* cppValue = V8bool::toImplWithTypeCheck(info.GetIsolate(), v8Value);
if (!cppValue) {
exceptionState.throwTypeError("The provided value is not of type 'bool'.");
- exceptionState.throwIfNeeded();
return;
}
impl->setSecureContextWorkerExposedRuntimeEnabledAttribute(cppValue);

Powered by Google App Engine
This is Rietveld 408576698