third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp - Issue 2272613003: binding: Retires ExceptionState::throwIfNeeded().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp

Issue 2272613003: binding: Retires ExceptionState::throwIfNeeded(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Synced. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp

diff --git a/third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp b/third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp

index 35d6afa57171c006c5b7d7af8e56b47d8147ccae..15651dff15f8f6eaede70731f35a71208ae7a4ea 100644

--- a/third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp

+++ b/third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp

@@ -130,8 +130,7 @@ bool parseQuad(std::unique_ptr<protocol::Array<double>> quadArray, FloatQuad* qu

v8::Local<v8::Value> nodeV8Value(v8::Local<v8::Context> context, Node* node)

{

v8::Isolate* isolate = context->GetIsolate();

- ExceptionState exceptionState(ExceptionState::ExecutionContext, "nodeV8Value", "InjectedScriptHost", context->Global(), isolate);

- if (!node || !BindingSecurity::shouldAllowAccessTo(currentDOMWindow(isolate), node, exceptionState))

+ if (!node || !BindingSecurity::shouldAllowAccessTo(currentDOMWindow(isolate), node, BindingSecurity::ErrorReportOption::DoNotReport))

return v8::Null(isolate);

return toV8(node, context->Global(), isolate);

}