Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Side by Side Diff: third_party/WebKit/Source/bindings/modules/v8/custom/V8IDBObserverCustom.cpp

Issue 2272613003: binding: Retires ExceptionState::throwIfNeeded(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Synced. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "bindings/modules/v8/V8IDBObserver.h" 5 #include "bindings/modules/v8/V8IDBObserver.h"
6 6
7 #include "bindings/core/v8/ExceptionMessages.h" 7 #include "bindings/core/v8/ExceptionMessages.h"
8 #include "bindings/core/v8/ExceptionState.h" 8 #include "bindings/core/v8/ExceptionState.h"
9 #include "bindings/core/v8/V8Binding.h" 9 #include "bindings/core/v8/V8Binding.h"
10 #include "bindings/core/v8/V8DOMWrapper.h" 10 #include "bindings/core/v8/V8DOMWrapper.h"
(...skipping 17 matching lines...) Expand all
28 } 28 }
29 29
30 if (info.Length() > 1 && !isUndefinedOrNull(info[1]) && !info[1]->IsObject() ) { 30 if (info.Length() > 1 && !isUndefinedOrNull(info[1]) && !info[1]->IsObject() ) {
31 V8ThrowException::throwTypeError(info.GetIsolate(), ExceptionMessages::f ailedToConstruct("IDBObserver", "IDBObserverInit (parameter 2) is not an object. ")); 31 V8ThrowException::throwTypeError(info.GetIsolate(), ExceptionMessages::f ailedToConstruct("IDBObserver", "IDBObserverInit (parameter 2) is not an object. "));
32 return; 32 return;
33 } 33 }
34 34
35 IDBObserverInit idbObserverInit; 35 IDBObserverInit idbObserverInit;
36 ExceptionState exceptionState(ExceptionState::ConstructionContext, "IDBObser ver", info.Holder(), info.GetIsolate()); 36 ExceptionState exceptionState(ExceptionState::ConstructionContext, "IDBObser ver", info.Holder(), info.GetIsolate());
37 V8IDBObserverInit::toImpl(info.GetIsolate(), info[1], idbObserverInit, excep tionState); 37 V8IDBObserverInit::toImpl(info.GetIsolate(), info[1], idbObserverInit, excep tionState);
38 if (exceptionState.throwIfNeeded()) 38 if (exceptionState.hadException())
39 return; 39 return;
40 40
41 IDBObserverCallback* callback = new V8IDBObserverCallback(v8::Local<v8::Func tion>::Cast(info[0]), wrapper, ScriptState::current(info.GetIsolate())); 41 IDBObserverCallback* callback = new V8IDBObserverCallback(v8::Local<v8::Func tion>::Cast(info[0]), wrapper, ScriptState::current(info.GetIsolate()));
42 IDBObserver* observer = IDBObserver::create(*callback, idbObserverInit); 42 IDBObserver* observer = IDBObserver::create(*callback, idbObserverInit);
43 if (exceptionState.throwIfNeeded()) 43 if (exceptionState.hadException())
44 return; 44 return;
45 DCHECK(observer); 45 DCHECK(observer);
46 v8SetReturnValue(info, V8DOMWrapper::associateObjectWithWrapper(info.GetIsol ate(), observer, &wrapperTypeInfo, wrapper)); 46 v8SetReturnValue(info, V8DOMWrapper::associateObjectWithWrapper(info.GetIsol ate(), observer, &wrapperTypeInfo, wrapper));
47 } 47 }
48 48
49 } // namespace blink 49 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698