third_party/WebKit/Source/bindings/scripts/v8_types.py - Issue 2272613003: binding: Retires ExceptionState::throwIfNeeded().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/scripts/v8_types.py

Issue 2272613003: binding: Retires ExceptionState::throwIfNeeded(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Synced. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/bindings/scripts/v8_types.py

diff --git a/third_party/WebKit/Source/bindings/scripts/v8_types.py b/third_party/WebKit/Source/bindings/scripts/v8_types.py

index 1fe8b5aced561215d284a302b4bec9f7b16c107f..08ffb704751d77a0b2702dd343083d8b4fbbabcc 100644

--- a/third_party/WebKit/Source/bindings/scripts/v8_types.py

+++ b/third_party/WebKit/Source/bindings/scripts/v8_types.py

@@ -626,10 +626,7 @@ def v8_value_to_local_cpp_value(idl_type, extended_attributes, v8_value, variabl

if idl_type.is_string_type or idl_type.v8_conversion_needs_exception_state:

# Types for which conversion can fail and that need error handling.

- if use_exception_state:

- check_expression = 'exceptionState.hadException()'

- else:

- check_expression = 'exceptionState.throwIfNeeded()'

+ check_expression = 'exceptionState.hadException()'

if idl_type.is_dictionary or idl_type.is_union_type:

set_expression = cpp_value