Add 'title' field to DownloadUIItem and thread through bridges to OfflinePageDownloadItem.

Add 'title' field to DownloadUIItem and thread through bridges to OfflinePageDownloadItem.
Also call destroy() on the bridge to fix mem leak

BUG=638395, 630817
Committed: https://crrev.com/a6e1def19ac161b674482e96e7d346dcfca2a92d
Cr-Commit-Position: refs/heads/master@{#413315}

[Dmitry Titov, 2016-08-19 22:17:42]

The CQ bit was checked by dimich@chromium.org to run a CQ dry run

[Dmitry Titov, 2016-08-19 22:18:10]

dimich@chromium.org changed reviewers:
+ fgorski@chromium.org

[commit-bot: I haz the power, 2016-08-19 22:18:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fgorski, 2016-08-19 22:51:09]

lgtm with nit.

https://codereview.chromium.org/2263753002/diff/1/chrome/android/junit/src/or...
File
chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/downloads/OfflinePageDownloadBridgeTest.java
(right):

https://codereview.chromium.org/2263753002/diff/1/chrome/android/junit/src/or...
chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/downloads/OfflinePageDownloadBridgeTest.java:143:
// nullptr as URL skips actual intent so no tabs are attempted to be created.
nit: null

[Dmitry Titov, 2016-08-19 22:55:13]

dimich@chromium.org changed reviewers:
+ dfalcantara@chromium.org

[Dmitry Titov, 2016-08-19 22:55:14]

+Dan for java parts.

Dan, this is adding 'title' to use instead of filename in UI (title may be empty
string, in which case filename can be used). We already populate it on our side.
Feel free to wire it up or tell me to do it :)

https://codereview.chromium.org/2263753002/diff/1/chrome/android/junit/src/or...
File
chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/downloads/OfflinePageDownloadBridgeTest.java
(right):

https://codereview.chromium.org/2263753002/diff/1/chrome/android/junit/src/or...
chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/downloads/OfflinePageDownloadBridgeTest.java:143:
// nullptr as URL skips actual intent so no tabs are attempted to be created.
On 2016/08/19 22:51:09, fgorski wrote:
> nit: null

Done.

[Dmitry Titov, 2016-08-19 22:55:36]

The CQ bit was checked by dimich@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-19 22:56:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gone, 2016-08-19 22:58:42]

Ah, cool.  I'll rebase my current CL on top of this guy and then add title
support on my end.

lgtm

[Dmitry Titov, 2016-08-19 23:07:44]

The CQ bit was unchecked by dimich@chromium.org

[Dmitry Titov, 2016-08-19 23:07:49]

The CQ bit was checked by dimich@chromium.org

[Dmitry Titov, 2016-08-19 23:07:49]

The patchset sent to the CQ was uploaded after l-g-t-m from fgorski@chromium.org
Link to the patchset: https://codereview.chromium.org/2263753002/#ps20001
(title: "CR feedback")

[commit-bot: I haz the power, 2016-08-19 23:08:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-20 00:46:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-20 00:46:19]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Dmitry Titov, 2016-08-20 00:55:12]

The CQ bit was checked by dimich@chromium.org

[commit-bot: I haz the power, 2016-08-20 00:55:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-20 01:45:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-20 01:45:01]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[gone, 2016-08-20 02:28:45]

The CQ bit was checked by dfalcantara@chromium.org

[commit-bot: I haz the power, 2016-08-20 02:29:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-20 03:55:20]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-20 03:57:01]

Description was changed from

==========
Add 'title' field to DownloadUIItem and thread through bridges to
OfflinePageDownloadItem.
Also call destroy() on the bridge to fix mem leak

BUG=638395,630817
==========

to

==========
Add 'title' field to DownloadUIItem and thread through bridges to
OfflinePageDownloadItem.
Also call destroy() on the bridge to fix mem leak

BUG=638395,630817

Committed: https://crrev.com/a6e1def19ac161b674482e96e7d346dcfca2a92d
Cr-Commit-Position: refs/heads/master@{#413315}
==========

[commit-bot: I haz the power, 2016-08-20 03:57:02]

Patchset 2 (id:??) landed as
https://crrev.com/a6e1def19ac161b674482e96e7d346dcfca2a92d
Cr-Commit-Position: refs/heads/master@{#413315}