chrome/android/java/src/org/chromium/chrome/browser/offlinepages/downloads/OfflinePageDownloadBridge.java - Issue 2263753002: Add 'title' field to DownloadUIItem and thread through bridges to OfflinePageDownloadItem.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/offlinepages/downloads/OfflinePageDownloadBridge.java

Issue 2263753002: Add 'title' field to DownloadUIItem and thread through bridges to OfflinePageDownloadItem. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: CR feedback Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/offlinepages/downloads/OfflinePageDownloadItem.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/offlinepages/downloads/OfflinePageDownloadBridge.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/downloads/OfflinePageDownloadBridge.java b/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/downloads/OfflinePageDownloadBridge.java

index 922ab83409b00a6ab41f458ae83ff8b7288ba5b1..5899eeac37cad2c65a5e1a93f6999bf72b9baa3c 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/downloads/OfflinePageDownloadBridge.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/downloads/OfflinePageDownloadBridge.java

@@ -232,14 +232,15 @@ public class OfflinePageDownloadBridge implements DownloadServiceDelegate {

@CalledByNative

static void createDownloadItemAndAddToList(List<OfflinePageDownloadItem> list, String guid,

- String url, String targetPath, long startTimeMs, long totalBytes) {

- list.add(createDownloadItem(guid, url, targetPath, startTimeMs, totalBytes));

+ String url, String title, String targetPath, long startTimeMs, long totalBytes) {

+ list.add(createDownloadItem(guid, url, title, targetPath, startTimeMs, totalBytes));

}

@CalledByNative

static OfflinePageDownloadItem createDownloadItem(

- String guid, String url, String targetPath, long startTimeMs, long totalBytes) {

- return new OfflinePageDownloadItem(guid, url, targetPath, startTimeMs, totalBytes);

+ String guid, String url, String title, String targetPath,

+ long startTimeMs, long totalBytes) {

+ return new OfflinePageDownloadItem(guid, url, title, targetPath, startTimeMs, totalBytes);

}

private native long nativeInit(Profile profile);