Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4320)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/offlinepages/downloads/OfflinePageDownloadItem.java

Issue 2263753002: Add 'title' field to DownloadUIItem and thread through bridges to OfflinePageDownloadItem. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: CR feedback Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/offlinepages/downloads/OfflinePageDownloadItem.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/downloads/OfflinePageDownloadItem.java b/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/downloads/OfflinePageDownloadItem.java
index 834b3fb6634b21b84bfaefcf7ca86ef25ba56c32..3ac4657dabdb9cb95e2462408573cde1dc765902 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/downloads/OfflinePageDownloadItem.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/downloads/OfflinePageDownloadItem.java
@@ -7,15 +7,18 @@ package org.chromium.chrome.browser.offlinepages.downloads;
/** Class representing offline page or save page request to downloads UI. */
public class OfflinePageDownloadItem {
private final String mUrl;
+ private final String mTitle;
private final String mGuid;
private final String mTargetPath;
private final long mStartTimeMs;
private final long mTotalBytes;
public OfflinePageDownloadItem(
- String guid, String url, String targetPath, long startTimeMs, long totalBytes) {
+ String guid, String url, String title, String targetPath,
+ long startTimeMs, long totalBytes) {
mGuid = guid;
mUrl = url;
+ mTitle = title;
mTargetPath = targetPath;
mStartTimeMs = startTimeMs;
mTotalBytes = totalBytes;
@@ -31,6 +34,11 @@ public class OfflinePageDownloadItem {
return mUrl;
}
+ /** @return Title of the page. */
+ public String getTitle() {
+ return mTitle;
+ }
+
/** @return Path to the offline item on the disk. */
// TODO(fgorski): Title would be more meaningful to show in the Download UI, where the local
// path is shown right now.

Powered by Google App Engine
This is Rietveld 408576698