components/offline_pages/downloads/download_ui_item.h - Issue 2263753002: Add 'title' field to DownloadUIItem and thread through bridges to OfflinePageDownloadItem.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/offline_pages/downloads/download_ui_item.h

Issue 2263753002: Add 'title' field to DownloadUIItem and thread through bridges to OfflinePageDownloadItem. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: CR feedback Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/offline_pages/downloads/download_ui_adapter_unittest.cc ('k') | components/offline_pages/downloads/download_ui_item.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/offline_pages/downloads/download_ui_item.h

diff --git a/components/offline_pages/downloads/download_ui_item.h b/components/offline_pages/downloads/download_ui_item.h

index 057266192efce5a5be71a463a454bc7056b98883..c720a583665d277a7eb8dbde9f8da962bc1f2345 100644

--- a/components/offline_pages/downloads/download_ui_item.h

+++ b/components/offline_pages/downloads/download_ui_item.h

@@ -28,6 +28,10 @@ struct DownloadUIItem {

// The URL of the captured page.

GURL url;

+ // The Title of the captured page, if any. It can be empty string either

+ // because the page is not yet fully loaded, or because it doesn't have any.

+ base::string16 title;

// The file path to the archive with a local copy of the page.

base::FilePath target_path;