[Download Home] Use OfflinePage titles & bolster tests

[Download Home] Use OfflinePage titles & bolster tests

* Show the title of the page instead of the filename for
  Offline Pages.

* Stub out the DownloadManagerService and OfflinePageDownloadsBridge
  for tests.

* Further isolate the DownloadManagerUi from the
  DownloadHistoryAdapter and its Observers, including
  properly fixing how the observers are removed.

* Revamp some of the existing tests and add new ones to check that
  Offline Pages are being accounted for correctly.

BUG=616324
Committed: https://crrev.com/472c4d3851673b997b3dac300049684ced815f5b
Cr-Commit-Position: refs/heads/master@{#413563}

[gone, 2016-08-19 23:08:54]

dfalcantara@chromium.org changed reviewers:
+ dimich@chromium.org, qinmin@google.com, twellington@chromium.org

[gone, 2016-08-19 23:08:54]

Min for changes to DownloadManagerService

Dmitry for changes involving
OfflinePageDownloadBridge/DownloadHistoryItemWrapper

Theresa for changes to the test and the resulting fallout in the other files.

[gone, 2016-08-19 23:24:54]

The CQ bit was checked by dfalcantara@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-19 23:25:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-19 23:28:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-19 23:28:38]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Dmitry Titov, 2016-08-20 00:20:44]

OfflineBridge/DownloadHistoryItemWrapper lgtm

[gone, 2016-08-22 00:43:21]

The CQ bit was checked by dfalcantara@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-22 00:43:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gone, 2016-08-22 02:49:15]

Description was changed from

==========
[Download Home] Use OfflinePage titles & bolster tests

* Show the title of the page instead of the filename for Offline Pages.

* Stub out the DownloadManagerService and OfflinePageDownloadsBridge
  for tests.

* Revamp some of the existing tests and add new ones to check that
  Offline Pages are being accounted for correctly.

BUG=616324
==========

to

==========
[Download Home] Use OfflinePage titles & bolster tests

* Show the title of the page instead of the filename for Offline Pages.

* Stub out the DownloadManagerService and OfflinePageDownloadsBridge
  for tests.

* Further isolate the DownloadManagerUi from the DownloadHistoryAdapter.

* Revamp some of the existing tests and add new ones to check that
  Offline Pages are being accounted for correctly.

BUG=616324
==========

[gone, 2016-08-22 02:49:44]

The CQ bit was checked by dfalcantara@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-22 02:50:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gone, 2016-08-22 02:50:24]

Description was changed from

==========
[Download Home] Use OfflinePage titles & bolster tests

* Show the title of the page instead of the filename for Offline Pages.

* Stub out the DownloadManagerService and OfflinePageDownloadsBridge
  for tests.

* Further isolate the DownloadManagerUi from the DownloadHistoryAdapter.

* Revamp some of the existing tests and add new ones to check that
  Offline Pages are being accounted for correctly.

BUG=616324
==========

to

==========
[Download Home] Use OfflinePage titles & bolster tests

* Show the title of the page instead of the filename for Offline Pages.

* Stub out the DownloadManagerService and OfflinePageDownloadsBridge
  for tests.

* Further isolate the DownloadManagerUi from the DownloadHistoryAdapter and its
Observers.

* Revamp some of the existing tests and add new ones to check that
  Offline Pages are being accounted for correctly.

BUG=616324
==========

[gone, 2016-08-22 02:50:44]

Description was changed from

==========
[Download Home] Use OfflinePage titles & bolster tests

* Show the title of the page instead of the filename for Offline Pages.

* Stub out the DownloadManagerService and OfflinePageDownloadsBridge
  for tests.

* Further isolate the DownloadManagerUi from the DownloadHistoryAdapter and its
Observers.

* Revamp some of the existing tests and add new ones to check that
  Offline Pages are being accounted for correctly.

BUG=616324
==========

to

==========
[Download Home] Use OfflinePage titles & bolster tests

* Show the title of the page instead of the filename for
   Offline Pages.

* Stub out the DownloadManagerService and OfflinePageDownloadsBridge
  for tests.

* Further isolate the DownloadManagerUi from the
   DownloadHistoryAdapter and its Observers.

* Revamp some of the existing tests and add new ones to check that
  Offline Pages are being accounted for correctly.

BUG=616324
==========

[gone, 2016-08-22 02:51:10]

Description was changed from

==========
[Download Home] Use OfflinePage titles & bolster tests

* Show the title of the page instead of the filename for
   Offline Pages.

* Stub out the DownloadManagerService and OfflinePageDownloadsBridge
  for tests.

* Further isolate the DownloadManagerUi from the
   DownloadHistoryAdapter and its Observers.

* Revamp some of the existing tests and add new ones to check that
  Offline Pages are being accounted for correctly.

BUG=616324
==========

to

==========
[Download Home] Use OfflinePage titles & bolster tests

* Show the title of the page instead of the filename for
   Offline Pages.

* Stub out the DownloadManagerService and OfflinePageDownloadsBridge
  for tests.

* Further isolate the DownloadManagerUi from the
  DownloadHistoryAdapter and its Observers.

* Revamp some of the existing tests and add new ones to check that
  Offline Pages are being accounted for correctly.

BUG=616324
==========

[gone, 2016-08-22 16:23:02]

The CQ bit was checked by dfalcantara@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-22 16:23:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gone, 2016-08-22 16:45:03]

Description was changed from

==========
[Download Home] Use OfflinePage titles & bolster tests

* Show the title of the page instead of the filename for
   Offline Pages.

* Stub out the DownloadManagerService and OfflinePageDownloadsBridge
  for tests.

* Further isolate the DownloadManagerUi from the
  DownloadHistoryAdapter and its Observers.

* Revamp some of the existing tests and add new ones to check that
  Offline Pages are being accounted for correctly.

BUG=616324
==========

to

==========
[Download Home] Use OfflinePage titles & bolster tests

* Show the title of the page instead of the filename for
  Offline Pages.

* Stub out the DownloadManagerService and OfflinePageDownloadsBridge
  for tests.

* Further isolate the DownloadManagerUi from the
  DownloadHistoryAdapter and its Observers, including
  properly fixing how the observers are removed.

* Revamp some of the existing tests and add new ones to check that
  Offline Pages are being accounted for correctly.

BUG=616324
==========

[qinmin, 2016-08-22 18:06:47]

qinmin@chromium.org changed reviewers:
+ qinmin@chromium.org

[qinmin, 2016-08-22 18:06:47]

lgtm

[Theresa, 2016-08-22 19:52:36]

lgtm

https://codereview.chromium.org/2266543003/diff/160001/chrome/android/java/sr...
File
chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryAdapter.java
(right):

https://codereview.chromium.org/2266543003/diff/160001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryAdapter.java:361:
if (getSelectionDelegate().isItemSelected(wrapper)) {
Just double checking, the selection delegate can no longer be null?

[gone, 2016-08-22 20:01:26]

Thanks!

https://codereview.chromium.org/2266543003/diff/160001/chrome/android/java/sr...
File
chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryAdapter.java
(right):

https://codereview.chromium.org/2266543003/diff/160001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryAdapter.java:361:
if (getSelectionDelegate().isItemSelected(wrapper)) {
On 2016/08/22 19:52:36, Theresa Wellington wrote:
> Just double checking, the selection delegate can no longer be null?

Yep, should always exist.

[gone, 2016-08-22 20:01:33]

The CQ bit was checked by dfalcantara@chromium.org

[gone, 2016-08-22 20:01:33]

The patchset sent to the CQ was uploaded after l-g-t-m from dimich@chromium.org,
twellington@chromium.org, qinmin@chromium.org
Link to the patchset: https://codereview.chromium.org/2266543003/#ps180001
(title: "setup")

[commit-bot: I haz the power, 2016-08-22 20:03:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-22 22:46:18]

Description was changed from

==========
[Download Home] Use OfflinePage titles & bolster tests

* Show the title of the page instead of the filename for
  Offline Pages.

* Stub out the DownloadManagerService and OfflinePageDownloadsBridge
  for tests.

* Further isolate the DownloadManagerUi from the
  DownloadHistoryAdapter and its Observers, including
  properly fixing how the observers are removed.

* Revamp some of the existing tests and add new ones to check that
  Offline Pages are being accounted for correctly.

BUG=616324
==========

to

==========
[Download Home] Use OfflinePage titles & bolster tests

* Show the title of the page instead of the filename for
  Offline Pages.

* Stub out the DownloadManagerService and OfflinePageDownloadsBridge
  for tests.

* Further isolate the DownloadManagerUi from the
  DownloadHistoryAdapter and its Observers, including
  properly fixing how the observers are removed.

* Revamp some of the existing tests and add new ones to check that
  Offline Pages are being accounted for correctly.

BUG=616324
==========

[commit-bot: I haz the power, 2016-08-22 22:46:19]

Committed patchset #10 (id:180001)

[commit-bot: I haz the power, 2016-08-22 22:50:55]

Description was changed from

==========
[Download Home] Use OfflinePage titles & bolster tests

* Show the title of the page instead of the filename for
  Offline Pages.

* Stub out the DownloadManagerService and OfflinePageDownloadsBridge
  for tests.

* Further isolate the DownloadManagerUi from the
  DownloadHistoryAdapter and its Observers, including
  properly fixing how the observers are removed.

* Revamp some of the existing tests and add new ones to check that
  Offline Pages are being accounted for correctly.

BUG=616324
==========

to

==========
[Download Home] Use OfflinePage titles & bolster tests

* Show the title of the page instead of the filename for
  Offline Pages.

* Stub out the DownloadManagerService and OfflinePageDownloadsBridge
  for tests.

* Further isolate the DownloadManagerUi from the
  DownloadHistoryAdapter and its Observers, including
  properly fixing how the observers are removed.

* Revamp some of the existing tests and add new ones to check that
  Offline Pages are being accounted for correctly.

BUG=616324

Committed: https://crrev.com/472c4d3851673b997b3dac300049684ced815f5b
Cr-Commit-Position: refs/heads/master@{#413563}
==========

[commit-bot: I haz the power, 2016-08-22 22:50:56]

Patchset 10 (id:??) landed as
https://crrev.com/472c4d3851673b997b3dac300049684ced815f5b
Cr-Commit-Position: refs/heads/master@{#413563}