Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1447)

Unified Diff: chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.cc

Issue 2263753002: Add 'title' field to DownloadUIItem and thread through bridges to OfflinePageDownloadItem. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: CR feedback Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.cc
diff --git a/chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.cc b/chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.cc
index a99688924993a3784e749a2552230bdfe8954bf3..2030056800e27d87453c2ad43fee3bbf12287df3 100644
--- a/chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.cc
+++ b/chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.cc
@@ -25,6 +25,7 @@
using base::android::AttachCurrentThread;
using base::android::ConvertJavaStringToUTF8;
using base::android::ConvertUTF8ToJavaString;
+using base::android::ConvertUTF16ToJavaString;
using base::android::JavaParamRef;
using base::android::ScopedJavaGlobalRef;
using base::android::ScopedJavaLocalRef;
@@ -42,6 +43,7 @@ void ToJavaOfflinePageDownloadItemList(
Java_OfflinePageDownloadBridge_createDownloadItemAndAddToList(
env, j_result_obj, ConvertUTF8ToJavaString(env, item->guid),
ConvertUTF8ToJavaString(env, item->url.spec()),
+ ConvertUTF16ToJavaString(env, item->title),
ConvertUTF8ToJavaString(env, item->target_path.value()),
item->start_time.ToJavaTime(), item->total_bytes);
}
@@ -53,6 +55,7 @@ ScopedJavaLocalRef<jobject> ToJavaOfflinePageDownloadItem(
return Java_OfflinePageDownloadBridge_createDownloadItem(
env, ConvertUTF8ToJavaString(env, item.guid),
ConvertUTF8ToJavaString(env, item.url.spec()),
+ ConvertUTF16ToJavaString(env, item.title),
ConvertUTF8ToJavaString(env, item.target_path.value()),
item.start_time.ToJavaTime(), item.total_bytes);
}

Powered by Google App Engine
This is Rietveld 408576698