Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 2258243002: Consistently use namespaced base::Version in chrome/installer. (Closed)

Created:
4 years, 4 months ago by pwnall
Modified:
4 years, 4 months ago
Reviewers:
grt (UTC plus 2)
CC:
chromium-reviews, grt+watch_chromium.org, pennymac+watch_chromium.org, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Consistently use namespaced base::Version in chrome/installer. BUG=639416 Committed: https://crrev.com/c3f931d06d184b5c2c7363bbd72ee00772fe6c76 Cr-Commit-Position: refs/heads/master@{#413537}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+137 lines, -132 lines) Patch
M chrome/installer/setup/install.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/installer/setup/install.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/installer/setup/install_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/installer/setup/install_worker.cc View 11 chunks +16 lines, -16 lines 0 comments Download
M chrome/installer/setup/install_worker_unittest.cc View 8 chunks +10 lines, -10 lines 0 comments Download
M chrome/installer/setup/setup_main.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/installer/setup/setup_util.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/setup/setup_util.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/installer/setup/setup_util_unittest.cc View 5 chunks +9 lines, -9 lines 0 comments Download
M chrome/installer/setup/uninstall.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/installer/test/alternate_version_generator.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/installer/util/browser_distribution.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/util/browser_distribution.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/util/fake_installation_state.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/installer/util/fake_product_state.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/util/google_chrome_distribution.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/util/google_chrome_distribution.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/util/google_update_settings.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/util/google_update_settings.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/installer/util/google_update_settings_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/util/install_util.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M chrome/installer/util/installation_state.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/installer/util/installation_state.cc View 3 chunks +6 lines, -5 lines 0 comments Download
M chrome/installer/util/installation_validator_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/util/installer_state.cc View 9 chunks +16 lines, -15 lines 0 comments Download
M chrome/installer/util/installer_state_unittest.cc View 15 chunks +34 lines, -33 lines 0 comments Download
M chrome/installer/util/product_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 20 (11 generated)
pwnall
Can you please take a look? This is a pretty mechanic CL.
4 years, 4 months ago (2016-08-19 20:20:33 UTC) #2
grt (UTC plus 2)
rslgtm
4 years, 4 months ago (2016-08-22 09:53:27 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2258243002/1
4 years, 4 months ago (2016-08-22 17:28:05 UTC) #10
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 4 months ago (2016-08-22 17:28:08 UTC) #12
grt (UTC plus 2)
hmm. make that rubberstamp lgtm. :-)
4 years, 4 months ago (2016-08-22 18:45:59 UTC) #13
pwnall
On 2016/08/22 18:45:59, grt (UTC plus 2) wrote: > hmm. make that rubberstamp lgtm. :-) ...
4 years, 4 months ago (2016-08-22 19:17:55 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2258243002/1
4 years, 4 months ago (2016-08-22 19:19:02 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-22 21:28:01 UTC) #18
commit-bot: I haz the power
4 years, 4 months ago (2016-08-22 21:29:02 UTC) #20
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c3f931d06d184b5c2c7363bbd72ee00772fe6c76
Cr-Commit-Position: refs/heads/master@{#413537}

Powered by Google App Engine
This is Rietveld 408576698