Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Side by Side Diff: chrome/installer/util/google_chrome_distribution.cc

Issue 2258243002: Consistently use namespaced base::Version in chrome/installer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // This file defines specific implementation of BrowserDistribution class for 5 // This file defines specific implementation of BrowserDistribution class for
6 // Google Chrome. 6 // Google Chrome.
7 7
8 #include "chrome/installer/util/google_chrome_distribution.h" 8 #include "chrome/installer/util/google_chrome_distribution.h"
9 9
10 #include <windows.h> 10 #include <windows.h>
(...skipping 88 matching lines...) Expand 10 before | Expand all | Expand 10 after
99 GoogleChromeDistribution::GoogleChromeDistribution() 99 GoogleChromeDistribution::GoogleChromeDistribution()
100 : BrowserDistribution(CHROME_BROWSER, 100 : BrowserDistribution(CHROME_BROWSER,
101 std::unique_ptr<AppRegistrationData>( 101 std::unique_ptr<AppRegistrationData>(
102 new UpdatingAppRegistrationData(kChromeGuid))) {} 102 new UpdatingAppRegistrationData(kChromeGuid))) {}
103 103
104 GoogleChromeDistribution::GoogleChromeDistribution( 104 GoogleChromeDistribution::GoogleChromeDistribution(
105 std::unique_ptr<AppRegistrationData> app_reg_data) 105 std::unique_ptr<AppRegistrationData> app_reg_data)
106 : BrowserDistribution(CHROME_BROWSER, std::move(app_reg_data)) {} 106 : BrowserDistribution(CHROME_BROWSER, std::move(app_reg_data)) {}
107 107
108 void GoogleChromeDistribution::DoPostUninstallOperations( 108 void GoogleChromeDistribution::DoPostUninstallOperations(
109 const Version& version, 109 const base::Version& version,
110 const base::FilePath& local_data_path, 110 const base::FilePath& local_data_path,
111 const base::string16& distribution_data) { 111 const base::string16& distribution_data) {
112 // Send the Chrome version and OS version as params to the form. 112 // Send the Chrome version and OS version as params to the form.
113 // It would be nice to send the locale, too, but I don't see an 113 // It would be nice to send the locale, too, but I don't see an
114 // easy way to get that in the existing code. It's something we 114 // easy way to get that in the existing code. It's something we
115 // can add later, if needed. 115 // can add later, if needed.
116 // We depend on installed_version.GetString() not having spaces or other 116 // We depend on installed_version.GetString() not having spaces or other
117 // characters that need escaping: 0.2.13.4. Should that change, we will 117 // characters that need escaping: 0.2.13.4. Should that change, we will
118 // need to escape the string before using it in a URL. 118 // need to escape the string before using it in a URL.
119 const base::string16 kVersionParam = L"crversion"; 119 const base::string16 kVersionParam = L"crversion";
(...skipping 159 matching lines...) Expand 10 before | Expand all | Expand 10 after
279 GetAppGuid()); 279 GetAppGuid());
280 } 280 }
281 281
282 bool GoogleChromeDistribution::ShouldSetExperimentLabels() { 282 bool GoogleChromeDistribution::ShouldSetExperimentLabels() {
283 return true; 283 return true;
284 } 284 }
285 285
286 bool GoogleChromeDistribution::HasUserExperiments() { 286 bool GoogleChromeDistribution::HasUserExperiments() {
287 return true; 287 return true;
288 } 288 }
OLDNEW
« no previous file with comments | « chrome/installer/util/google_chrome_distribution.h ('k') | chrome/installer/util/google_update_settings.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698