chrome/installer/util/product_unittest.cc - Issue 2258243002: Consistently use namespaced base::Version in chrome/installer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/installer/util/product_unittest.cc

Issue 2258243002: Consistently use namespaced base::Version in chrome/installer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/installer/util/product_unittest.cc

diff --git a/chrome/installer/util/product_unittest.cc b/chrome/installer/util/product_unittest.cc

index 82d89bb015956bd0f86e2fd8b48a172d034dc0b1..8a58ebc1b4afb4ae220b0e781a20abc2398681ec 100644

--- a/chrome/installer/util/product_unittest.cc

+++ b/chrome/installer/util/product_unittest.cc

@@ -67,7 +67,7 @@ TEST(ProductTest, ProductInstallBasic) {

ASSERT_TRUE(version_key.Valid());

const char kCurrentVersion[] = "1.2.3.4";

- Version current_version(kCurrentVersion);

+ base::Version current_version(kCurrentVersion);

version_key.WriteValue(google_update::kRegVersionField,

base::UTF8ToWide(

current_version.GetString()).c_str());

« no previous file with comments | « chrome/installer/util/installer_state_unittest.cc ('k') | no next file » | no next file with comments »