chrome/installer/setup/uninstall.cc - Issue 2258243002: Consistently use namespaced base::Version in chrome/installer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/installer/setup/uninstall.cc

Issue 2258243002: Consistently use namespaced base::Version in chrome/installer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/installer/setup/uninstall.cc

diff --git a/chrome/installer/setup/uninstall.cc b/chrome/installer/setup/uninstall.cc

index 4a2760bcbbee33825eb0006fec493689f68d6377..b1c5c5b30caf7aa0a3406be6c7987778f4524bb5 100644

--- a/chrome/installer/setup/uninstall.cc

+++ b/chrome/installer/setup/uninstall.cc

@@ -165,8 +165,8 @@ void ProcessChromeWorkItems(const InstallerState& installer_state,

"Cleanup OS upgrade command and deprecated per-user registrations");

work_item_list->set_best_effort(true);

work_item_list->set_rollback_enabled(false);

- AddOsUpgradeWorkItems(installer_state, base::FilePath(), Version(), product,

- work_item_list.get());

+ AddOsUpgradeWorkItems(installer_state, base::FilePath(), base::Version(),

+ product, work_item_list.get());

// Perform a best-effort cleanup of per-user keys. On system-level installs

// this will only cleanup keys for the user running the uninstall but it was

// considered that this was good enough (better than triggering Active Setup

« no previous file with comments | « chrome/installer/setup/setup_util_unittest.cc ('k') | chrome/installer/test/alternate_version_generator.cc » ('j') | no next file with comments »