chrome/installer/setup/setup_util.h - Issue 2258243002: Consistently use namespaced base::Version in chrome/installer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/installer/setup/setup_util.h

Issue 2258243002: Consistently use namespaced base::Version in chrome/installer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/installer/setup/setup_util.h

diff --git a/chrome/installer/setup/setup_util.h b/chrome/installer/setup/setup_util.h

index 485a1e6654a9e8575a1bfd2bab1db2eed95673e7..77ca45bfd431978cd1d8d9d15e16545e3abd1d11 100644

--- a/chrome/installer/setup/setup_util.h

+++ b/chrome/installer/setup/setup_util.h

@@ -53,7 +53,7 @@ int BsdiffPatchFiles(const base::FilePath& src,

// Find the version of Chrome from an install source directory.

// Chrome_path should contain at least one version folder.

// Returns the maximum version found or NULL if no version is found.

-Version* GetMaxVersionFromArchiveDir(const base::FilePath& chrome_path);

+base::Version* GetMaxVersionFromArchiveDir(const base::FilePath& chrome_path);

// Returns the uncompressed archive of the installed version that serves as the

// source for patching. If |desired_version| is valid, only the path to that

« no previous file with comments | « chrome/installer/setup/setup_main.cc ('k') | chrome/installer/setup/setup_util.cc » ('j') | no next file with comments »