Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4752)

Unified Diff: chrome/installer/util/google_update_settings.cc

Issue 2258243002: Consistently use namespaced base::Version in chrome/installer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/installer/util/google_update_settings.cc
diff --git a/chrome/installer/util/google_update_settings.cc b/chrome/installer/util/google_update_settings.cc
index 519c433244e33185eeedf001a562455e80956cd5..747da1c7b64481bbc727f003ced287996ccd71fc 100644
--- a/chrome/installer/util/google_update_settings.cc
+++ b/chrome/installer/util/google_update_settings.cc
@@ -869,7 +869,8 @@ base::string16 GoogleUpdateSettings::GetUninstallCommandLine(
return cmd_line;
}
-Version GoogleUpdateSettings::GetGoogleUpdateVersion(bool system_install) {
+base::Version GoogleUpdateSettings::GetGoogleUpdateVersion(
+ bool system_install) {
const HKEY root_key = system_install ? HKEY_LOCAL_MACHINE : HKEY_CURRENT_USER;
base::string16 version;
RegKey key;
@@ -879,10 +880,10 @@ Version GoogleUpdateSettings::GetGoogleUpdateVersion(bool system_install) {
KEY_QUERY_VALUE | KEY_WOW64_32KEY) == ERROR_SUCCESS &&
key.ReadValue(google_update::kRegGoogleUpdateVersion, &version) ==
ERROR_SUCCESS) {
- return Version(base::UTF16ToUTF8(version));
+ return base::Version(base::UTF16ToUTF8(version));
}
- return Version();
+ return base::Version();
}
base::Time GoogleUpdateSettings::GetGoogleUpdateLastStartedAU(
« no previous file with comments | « chrome/installer/util/google_update_settings.h ('k') | chrome/installer/util/google_update_settings_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698