Remove test-only constructor from CreditCard.

Remove test-only constructor from CreditCard.

BUG=637896
Committed: https://crrev.com/4d2cbc629a956f52ecee1323d7757c3274a143ba
Cr-Commit-Position: refs/heads/master@{#413815}

[please use gerrit instead, 2016-08-17 21:14:16]

The CQ bit was checked by rouslan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-17 21:14:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-17 21:35:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-17 21:35:28]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)

[please use gerrit instead, 2016-08-17 22:09:08]

The CQ bit was checked by rouslan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-17 22:09:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-17 22:52:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-17 22:52:40]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[please use gerrit instead, 2016-08-18 00:28:51]

Patchset #1 (id:1) has been deleted

[please use gerrit instead, 2016-08-18 00:29:00]

Description was changed from

==========
Remove test-only constructor from CreditCard.

BUG=NONE
==========

to

==========
Remove test-only constructor from CreditCard.

BUG=637896
==========

[please use gerrit instead, 2016-08-18 00:29:19]

rouslan@chromium.org changed reviewers:
+ estade@chromium.org

[please use gerrit instead, 2016-08-18 00:29:19]

Evan, ptal.

[Evan Stade, 2016-08-18 00:48:56]

https://codereview.chromium.org/2254983002/diff/20001/components/autofill/cor...
File components/autofill/core/browser/autofill_external_delegate_unittest.cc
(right):

https://codereview.chromium.org/2254983002/diff/20001/components/autofill/cor...
components/autofill/core/browser/autofill_external_delegate_unittest.cc:625:
CreditCard card(base::GenerateGUID(), std::string());
I'd suggest adding something to autofill_test_utils to streamline this

[please use gerrit instead, 2016-08-19 23:05:36]

The CQ bit was checked by rouslan@chromium.org to run a CQ dry run

[please use gerrit instead, 2016-08-19 23:05:49]

Evan, ptal patch 2.

https://codereview.chromium.org/2254983002/diff/20001/components/autofill/cor...
File components/autofill/core/browser/autofill_external_delegate_unittest.cc
(right):

https://codereview.chromium.org/2254983002/diff/20001/components/autofill/cor...
components/autofill/core/browser/autofill_external_delegate_unittest.cc:625:
CreditCard card(base::GenerateGUID(), std::string());
On 2016/08/18 00:48:55, Evan Stade wrote:
> I'd suggest adding something to autofill_test_utils to streamline this

There's already autofill::test::SetCreditCardInfo(), so I'm using that.

[commit-bot: I haz the power, 2016-08-19 23:06:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-20 03:10:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-20 03:10:13]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Evan Stade, 2016-08-22 14:52:16]

thanks, lgtm

[please use gerrit instead, 2016-08-22 16:26:04]

rouslan@chromium.org changed reviewers:
+ michaeln@chromium.org, miguelg@chromium.org

[please use gerrit instead, 2016-08-22 16:26:05]

michaeln, owners ptal autofill_counter_browsertest.cc (first file).

Miguel, owners ptal credit_card_scanner_view_android.cc (second file).

[michaeln, 2016-08-22 19:32:32]

> michaeln, owners ptal autofill_counter_browsertest.cc (first file).

r/s lgtm

[please use gerrit instead, 2016-08-23 18:13:28]

rouslan@chromium.org changed reviewers:
- miguelg@chromium.org

[please use gerrit instead, 2016-08-23 18:15:14]

rouslan@chromium.org changed reviewers:
+ msw@chromium.org

[please use gerrit instead, 2016-08-23 18:15:15]

msw, owners ptal credit_card_scanner_view_android.cc (second file)

[msw, 2016-08-23 18:23:04]

lgtm with nits.

https://codereview.chromium.org/2254983002/diff/40001/chrome/browser/ui/andro...
File chrome/browser/ui/android/autofill/credit_card_scanner_view_android.cc
(right):

https://codereview.chromium.org/2254983002/diff/40001/chrome/browser/ui/andro...
chrome/browser/ui/android/autofill/credit_card_scanner_view_android.cc:77:
CreditCard card(base::GenerateGUID(), std::string());
optional nit: use default ctor instead and nix base/guid.h include?

https://codereview.chromium.org/2254983002/diff/40001/components/autofill/cor...
File components/autofill/core/browser/credit_card_unittest.cc (right):

https://codereview.chromium.org/2254983002/diff/40001/components/autofill/cor...
components/autofill/core/browser/credit_card_unittest.cc:886: CreditCard
card(base::GenerateGUID(), std::string());
ditto optional nit: use default ctor?

[please use gerrit instead, 2016-08-23 18:42:32]

Sending to cq.

https://codereview.chromium.org/2254983002/diff/40001/chrome/browser/ui/andro...
File chrome/browser/ui/android/autofill/credit_card_scanner_view_android.cc
(right):

https://codereview.chromium.org/2254983002/diff/40001/chrome/browser/ui/andro...
chrome/browser/ui/android/autofill/credit_card_scanner_view_android.cc:77:
CreditCard card(base::GenerateGUID(), std::string());
On 2016/08/23 18:23:03, msw wrote:
> optional nit: use default ctor instead and nix base/guid.h include?

Done.

https://codereview.chromium.org/2254983002/diff/40001/components/autofill/cor...
File components/autofill/core/browser/credit_card_unittest.cc (right):

https://codereview.chromium.org/2254983002/diff/40001/components/autofill/cor...
components/autofill/core/browser/credit_card_unittest.cc:886: CreditCard
card(base::GenerateGUID(), std::string());
On 2016/08/23 18:23:03, msw wrote:
> ditto optional nit: use default ctor?

Done.

[please use gerrit instead, 2016-08-23 18:44:15]

The CQ bit was checked by rouslan@chromium.org

[please use gerrit instead, 2016-08-23 18:44:16]

The patchset sent to the CQ was uploaded after l-g-t-m from
michaeln@chromium.org, msw@chromium.org, estade@chromium.org
Link to the patchset: https://codereview.chromium.org/2254983002/#ps60001
(title: "Use default constructor and nix guid include")

[commit-bot: I haz the power, 2016-08-23 18:44:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-23 19:41:36]

Description was changed from

==========
Remove test-only constructor from CreditCard.

BUG=637896
==========

to

==========
Remove test-only constructor from CreditCard.

BUG=637896
==========

[commit-bot: I haz the power, 2016-08-23 19:41:37]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-08-23 19:42:47]

Description was changed from

==========
Remove test-only constructor from CreditCard.

BUG=637896
==========

to

==========
Remove test-only constructor from CreditCard.

BUG=637896

Committed: https://crrev.com/4d2cbc629a956f52ecee1323d7757c3274a143ba
Cr-Commit-Position: refs/heads/master@{#413815}
==========

[commit-bot: I haz the power, 2016-08-23 19:42:49]

Patchset 3 (id:??) landed as
https://crrev.com/4d2cbc629a956f52ecee1323d7757c3274a143ba
Cr-Commit-Position: refs/heads/master@{#413815}