Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Unified Diff: components/autofill/core/browser/credit_card_unittest.cc

Issue 2254983002: Remove test-only constructor from CreditCard. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Use default constructor and nix guid include Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/core/browser/credit_card_unittest.cc
diff --git a/components/autofill/core/browser/credit_card_unittest.cc b/components/autofill/core/browser/credit_card_unittest.cc
index a6e13a59076b2a26060002b44b484fe548076aa4..d61bbe3fa73505dea124fbeb91679e2507a8af17 100644
--- a/components/autofill/core/browser/credit_card_unittest.cc
+++ b/components/autofill/core/browser/credit_card_unittest.cc
@@ -796,16 +796,6 @@ TEST(CreditCardTest, LastFourDigits) {
ASSERT_EQ(base::ASCIIToUTF16("489"), card.LastFourDigits());
}
-TEST(CreditCardTest, CanBuildFromCardNumberAndExpirationDate) {
- base::string16 card_number = base::ASCIIToUTF16("test");
- int month = 1;
- int year = 2999;
- CreditCard card(card_number, month, year);
- EXPECT_EQ(card_number, card.number());
- EXPECT_EQ(month, card.expiration_month());
- EXPECT_EQ(year, card.expiration_year());
-}
-
// Verifies that a credit card should be updated.
TEST(CreditCardTest, ShouldUpdateExpiration) {
base::Time now = base::Time::Now();
@@ -893,8 +883,9 @@ TEST(CreditCardTest, ShouldUpdateExpiration) {
};
for (size_t i = 0; i < arraysize(kTestCases); ++i) {
- CreditCard card(base::ASCIIToUTF16("1234"), kTestCases[i].month,
- kTestCases[i].year);
+ CreditCard card;
+ card.SetExpirationMonth(kTestCases[i].month);
+ card.SetExpirationYear(kTestCases[i].year);
card.set_record_type(kTestCases[i].record_type);
if (card.record_type() != CreditCard::LOCAL_CARD)
card.SetServerStatus(kTestCases[i].server_status);

Powered by Google App Engine
This is Rietveld 408576698