chrome/browser/ui/android/autofill/credit_card_scanner_view_android.cc - Issue 2254983002: Remove test-only constructor from CreditCard.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/android/autofill/credit_card_scanner_view_android.cc

Issue 2254983002: Remove test-only constructor from CreditCard. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Use default constructor and nix guid include Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/browsing_data/autofill_counter_browsertest.cc ('k') | components/autofill/core/browser/autofill_external_delegate_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/android/autofill/credit_card_scanner_view_android.cc

diff --git a/chrome/browser/ui/android/autofill/credit_card_scanner_view_android.cc b/chrome/browser/ui/android/autofill/credit_card_scanner_view_android.cc

index ef1b3bc0dc3c6ca81ee626ead2c3188453971704..14b5d82806c5c8bee42737017856f346273e31e7 100644

--- a/chrome/browser/ui/android/autofill/credit_card_scanner_view_android.cc

+++ b/chrome/browser/ui/android/autofill/credit_card_scanner_view_android.cc

@@ -75,11 +75,14 @@ void CreditCardScannerViewAndroid::ScanCompleted(

const JavaParamRef<jstring>& card_number,

jint expiration_month,

jint expiration_year) {

- CreditCard card(base::android::ConvertJavaStringToUTF16(env, card_number),

- static_cast<int>(expiration_month), static_cast<int>(expiration_year));

+ CreditCard card;

+ card.SetNumber(base::android::ConvertJavaStringToUTF16(env, card_number));

+ card.SetExpirationMonth(static_cast<int>(expiration_month));

+ card.SetExpirationYear(static_cast<int>(expiration_year));

if (base::FeatureList::IsEnabled(kAutofillScanCardholderName)) {

- card.SetRawInfo(CREDIT_CARD_NAME_FULL,

+ card.SetRawInfo(

+ CREDIT_CARD_NAME_FULL,

base::android::ConvertJavaStringToUTF16(env, card_holder_name));

}