Remove test-only constructor from CreditCard.

components/autofill/core/browser/credit_card_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stddef.h>
 
 #include "base/guid.h"
 #include "base/macros.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/utf_string_conversions.h"
@@ skipping 778 matching lines @@
                           "5212341234123489", "01", "2010");
   ASSERT_EQ(base::ASCIIToUTF16("3489"), card.LastFourDigits());
 
   card.SetRawInfo(CREDIT_CARD_NUMBER, ASCIIToUTF16("3489"));
   ASSERT_EQ(base::ASCIIToUTF16("3489"), card.LastFourDigits());
 
   card.SetRawInfo(CREDIT_CARD_NUMBER, ASCIIToUTF16("489"));
   ASSERT_EQ(base::ASCIIToUTF16("489"), card.LastFourDigits());
 }
 
-TEST(CreditCardTest, CanBuildFromCardNumberAndExpirationDate) {
-  base::string16 card_number = base::ASCIIToUTF16("test");
-  int month = 1;
-  int year = 2999;
-  CreditCard card(card_number, month, year);
-  EXPECT_EQ(card_number, card.number());
-  EXPECT_EQ(month, card.expiration_month());
-  EXPECT_EQ(year, card.expiration_year());
-}
-
 // Verifies that a credit card should be updated.
 TEST(CreditCardTest, ShouldUpdateExpiration) {
   base::Time now = base::Time::Now();
 
   base::Time::Exploded last_year;
   (now - base::TimeDelta::FromDays(365)).LocalExplode(&last_year);
 
   base::Time::Exploded last_month;
   (now - base::TimeDelta::FromDays(31)).LocalExplode(&last_month);
 
@@ skipping 67 matching lines @@
        CreditCard::OK},
       {false, next_year.month, next_year.year, CreditCard::FULL_SERVER_CARD,
        CreditCard::OK},
       {true, next_year.month, next_year.year, CreditCard::MASKED_SERVER_CARD,
        CreditCard::EXPIRED},
       {true, next_year.month, next_year.year, CreditCard::FULL_SERVER_CARD,
        CreditCard::EXPIRED},
   };
 
   for (size_t i = 0; i < arraysize(kTestCases); ++i) {
-    CreditCard card(base::ASCIIToUTF16("1234"), kTestCases[i].month,
-                    kTestCases[i].year);
+    CreditCard card(base::GenerateGUID(), std::string());

[msw, 2016/08/23 18:23:03]

ditto optional nit: use default ctor?

[please use gerrit instead, 2016/08/23 18:42:32]

Done.

+    card.SetExpirationMonth(kTestCases[i].month);
+    card.SetExpirationYear(kTestCases[i].year);
     card.set_record_type(kTestCases[i].record_type);
     if (card.record_type() != CreditCard::LOCAL_CARD)
       card.SetServerStatus(kTestCases[i].server_status);
 
     EXPECT_EQ(kTestCases[i].should_update_expiration,
               card.ShouldUpdateExpiration(now));
   }
 }
 
 }  // namespace autofill