Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Side by Side Diff: chrome/browser/ui/android/autofill/credit_card_scanner_view_android.cc

Issue 2254983002: Remove test-only constructor from CreditCard. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Use default constructor and nix guid include Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/android/autofill/credit_card_scanner_view_android.h" 5 #include "chrome/browser/ui/android/autofill/credit_card_scanner_view_android.h"
6 6
7 #include <memory> 7 #include <memory>
8 8
9 #include "base/android/context_utils.h" 9 #include "base/android/context_utils.h"
10 #include "base/android/jni_android.h" 10 #include "base/android/jni_android.h"
(...skipping 57 matching lines...) Expand 10 before | Expand all | Expand 10 after
68 delegate_->ScanCancelled(); 68 delegate_->ScanCancelled();
69 } 69 }
70 70
71 void CreditCardScannerViewAndroid::ScanCompleted( 71 void CreditCardScannerViewAndroid::ScanCompleted(
72 JNIEnv* env, 72 JNIEnv* env,
73 const JavaParamRef<jobject>& object, 73 const JavaParamRef<jobject>& object,
74 const JavaParamRef<jstring>& card_holder_name, 74 const JavaParamRef<jstring>& card_holder_name,
75 const JavaParamRef<jstring>& card_number, 75 const JavaParamRef<jstring>& card_number,
76 jint expiration_month, 76 jint expiration_month,
77 jint expiration_year) { 77 jint expiration_year) {
78 CreditCard card(base::android::ConvertJavaStringToUTF16(env, card_number), 78 CreditCard card;
79 static_cast<int>(expiration_month), static_cast<int>(expiration_year)); 79 card.SetNumber(base::android::ConvertJavaStringToUTF16(env, card_number));
80 card.SetExpirationMonth(static_cast<int>(expiration_month));
81 card.SetExpirationYear(static_cast<int>(expiration_year));
80 82
81 if (base::FeatureList::IsEnabled(kAutofillScanCardholderName)) { 83 if (base::FeatureList::IsEnabled(kAutofillScanCardholderName)) {
82 card.SetRawInfo(CREDIT_CARD_NAME_FULL, 84 card.SetRawInfo(
85 CREDIT_CARD_NAME_FULL,
83 base::android::ConvertJavaStringToUTF16(env, card_holder_name)); 86 base::android::ConvertJavaStringToUTF16(env, card_holder_name));
84 } 87 }
85 88
86 delegate_->ScanCompleted(card); 89 delegate_->ScanCompleted(card);
87 } 90 }
88 91
89 void CreditCardScannerViewAndroid::Show() { 92 void CreditCardScannerViewAndroid::Show() {
90 JNIEnv* env = base::android::AttachCurrentThread(); 93 JNIEnv* env = base::android::AttachCurrentThread();
91 Java_CreditCardScanner_scan(env, java_object_); 94 Java_CreditCardScanner_scan(env, java_object_);
92 } 95 }
93 96
94 } // namespace autofill 97 } // namespace autofill
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698