Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1026)

Unified Diff: components/autofill/core/browser/autofill_metrics_unittest.cc

Issue 2254983002: Remove test-only constructor from CreditCard. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Use default constructor and nix guid include Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/core/browser/autofill_metrics_unittest.cc
diff --git a/components/autofill/core/browser/autofill_metrics_unittest.cc b/components/autofill/core/browser/autofill_metrics_unittest.cc
index c19f5c2247130ff8a93c82d6c8e0877a9f047594..e5695a03c36dff87bdcf49efc1d7b34d8028f3ee 100644
--- a/components/autofill/core/browser/autofill_metrics_unittest.cc
+++ b/components/autofill/core/browser/autofill_metrics_unittest.cc
@@ -155,23 +155,24 @@ class TestPersonalDataManager : public PersonalDataManager {
local_credit_cards_.clear();
server_credit_cards_.clear();
if (include_local_credit_card) {
- CreditCard* credit_card =
- new CreditCard(base::ASCIIToUTF16("4111111111111111"), 12, 24);
- credit_card->set_guid("10000000-0000-0000-0000-000000000001");
- local_credit_cards_.push_back(credit_card);
+ std::unique_ptr<CreditCard> credit_card(new CreditCard(
+ "10000000-0000-0000-0000-000000000001", std::string()));
+ test::SetCreditCardInfo(credit_card.get(), nullptr, "4111111111111111",
+ "12", "24");
+ local_credit_cards_.push_back(credit_card.release());
}
if (include_masked_server_credit_card) {
- CreditCard* credit_card = new CreditCard(
- CreditCard::MASKED_SERVER_CARD, "server_id");
+ std::unique_ptr<CreditCard> credit_card(new CreditCard(
+ CreditCard::MASKED_SERVER_CARD, "server_id"));
credit_card->set_guid("10000000-0000-0000-0000-000000000002");
credit_card->SetTypeForMaskedCard(kDiscoverCard);
- server_credit_cards_.push_back(credit_card);
+ server_credit_cards_.push_back(credit_card.release());
}
if (include_full_server_credit_card) {
- CreditCard* credit_card = new CreditCard(
- CreditCard::FULL_SERVER_CARD, "server_id");
+ std::unique_ptr<CreditCard> credit_card(new CreditCard(
+ CreditCard::FULL_SERVER_CARD, "server_id"));
credit_card->set_guid("10000000-0000-0000-0000-000000000003");
- server_credit_cards_.push_back(credit_card);
+ server_credit_cards_.push_back(credit_card.release());
}
Refresh();
}

Powered by Google App Engine
This is Rietveld 408576698