third_party/WebKit/Source/platform/mojo/KURLStructTraits.h - Issue 2253293002: Mojo C++ bindings: change the first template parameter of StructTraits and UnionTraits.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/mojo/KURLStructTraits.h

Issue 2253293002: Mojo C++ bindings: change the first template parameter of StructTraits and UnionTraits. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@91_extra

Patch Set: rebase Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « skia/public/interfaces/image_filter_struct_traits.h ('k') | third_party/WebKit/Source/platform/mojo/SecurityOriginStructTraits.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/mojo/KURLStructTraits.h

diff --git a/third_party/WebKit/Source/platform/mojo/KURLStructTraits.h b/third_party/WebKit/Source/platform/mojo/KURLStructTraits.h

index 3971b4a82aff0e95ccf1418d55ab14d540662f65..7feb5273585047941a298eb6dd16ea78dd5a61d5 100644

--- a/third_party/WebKit/Source/platform/mojo/KURLStructTraits.h

+++ b/third_party/WebKit/Source/platform/mojo/KURLStructTraits.h

@@ -13,7 +13,7 @@

namespace mojo {

template <>

-struct StructTraits<url::mojom::blink::Url, ::blink::KURL> {

+struct StructTraits<url::mojom::blink::Url::DataView, ::blink::KURL> {

static WTF::String url(const ::blink::KURL& blinkUrl)

{

if (!blinkUrl.isValid() || blinkUrl.getString().length() > url::kMaxURLChars) {

@@ -22,7 +22,7 @@ struct StructTraits<url::mojom::blink::Url, ::blink::KURL> {

return blinkUrl.getString();

}

- static bool Read(url::mojom::blink::UrlDataView data, ::blink::KURL* out)

+ static bool Read(url::mojom::blink::Url::DataView data, ::blink::KURL* out)

{

WTF::String urlString;

if (!data.ReadUrl(&urlString))