mojo/public/tools/bindings/generators/cpp_templates/struct_serialization_definition.tmpl - Issue 2253293002: Mojo C++ bindings: change the first template parameter of StructTraits and UnionTraits.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/tools/bindings/generators/cpp_templates/struct_serialization_definition.tmpl

Issue 2253293002: Mojo C++ bindings: change the first template parameter of StructTraits and UnionTraits. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@91_extra

Patch Set: rebase Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « mojo/public/tools/bindings/generators/cpp_templates/struct_serialization_declaration.tmpl ('k') | mojo/public/tools/bindings/generators/cpp_templates/union_serialization_declaration.tmpl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/public/tools/bindings/generators/cpp_templates/struct_serialization_definition.tmpl

diff --git a/mojo/public/tools/bindings/generators/cpp_templates/struct_serialization_definition.tmpl b/mojo/public/tools/bindings/generators/cpp_templates/struct_serialization_definition.tmpl

index 7421abcd787e0b370a25296e67053ca7ffdaf5a0..f84337f5bf4c7d8898cd116a90a253fc94cb433c 100644

--- a/mojo/public/tools/bindings/generators/cpp_templates/struct_serialization_definition.tmpl

+++ b/mojo/public/tools/bindings/generators/cpp_templates/struct_serialization_definition.tmpl

@@ -2,8 +2,8 @@

{%- set mojom_type = struct|get_qualified_name_for_kind %}

// static

-bool StructTraits<{{mojom_type}}, {{mojom_type}}Ptr>::Read(

- {{mojom_type}}DataView input,

+bool StructTraits<{{mojom_type}}::DataView, {{mojom_type}}Ptr>::Read(

+ {{mojom_type}}::DataView input,

{{mojom_type}}Ptr* output) {

bool success = true;

{{mojom_type}}Ptr result({{mojom_type}}::New());