components/metrics/public/cpp/call_stack_profile_struct_traits.h - Issue 2253293002: Mojo C++ bindings: change the first template parameter of StructTraits and UnionTraits.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/metrics/public/cpp/call_stack_profile_struct_traits.h

Issue 2253293002: Mojo C++ bindings: change the first template parameter of StructTraits and UnionTraits. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@91_extra

Patch Set: rebase Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/content/public/cpp/autofill_types_struct_traits.cc ('k') | components/password_manager/content/public/cpp/credential_manager_struct_traits.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/metrics/public/cpp/call_stack_profile_struct_traits.h

diff --git a/components/metrics/public/cpp/call_stack_profile_struct_traits.h b/components/metrics/public/cpp/call_stack_profile_struct_traits.h

index a9b2b280a2acdb2976f4fd5bdbc9d9cf977d9d2e..4242d85e73cc7eebe1e861079916d99e710d41eb 100644

--- a/components/metrics/public/cpp/call_stack_profile_struct_traits.h

+++ b/components/metrics/public/cpp/call_stack_profile_struct_traits.h

@@ -17,7 +17,7 @@

namespace mojo {

template <>

-struct StructTraits<metrics::mojom::CallStackModule,

+struct StructTraits<metrics::mojom::CallStackModuleDataView,

base::StackSamplingProfiler::Module> {

static uint64_t base_address(

const base::StackSamplingProfiler::Module& module) {

@@ -50,7 +50,7 @@ struct StructTraits<metrics::mojom::CallStackModule,

};

template <>

-struct StructTraits<metrics::mojom::CallStackFrame,

+struct StructTraits<metrics::mojom::CallStackFrameDataView,

base::StackSamplingProfiler::Frame> {

static uint64_t instruction_pointer(

const base::StackSamplingProfiler::Frame& frame) {

@@ -80,7 +80,7 @@ struct StructTraits<metrics::mojom::CallStackFrame,

};

template <>

-struct StructTraits<metrics::mojom::CallStackProfile,

+struct StructTraits<metrics::mojom::CallStackProfileDataView,

base::StackSamplingProfiler::CallStackProfile> {

static const std::vector<base::StackSamplingProfiler::Module>& modules(

const base::StackSamplingProfiler::CallStackProfile& profile) {