components/password_manager/content/public/cpp/credential_manager_struct_traits.cc - Issue 2253293002: Mojo C++ bindings: change the first template parameter of StructTraits and UnionTraits.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/content/public/cpp/credential_manager_struct_traits.cc

Issue 2253293002: Mojo C++ bindings: change the first template parameter of StructTraits and UnionTraits. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@91_extra

Patch Set: rebase Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager/content/public/cpp/credential_manager_struct_traits.h ('k') | components/translate/content/common/translate_struct_traits.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/content/public/cpp/credential_manager_struct_traits.cc

diff --git a/components/password_manager/content/public/cpp/credential_manager_struct_traits.cc b/components/password_manager/content/public/cpp/credential_manager_struct_traits.cc

index 402c5acaaca1730028a10f747b51a78f5da95817..1b780069f4ae47aab4e3cb175e5ad094344c5478 100644

--- a/components/password_manager/content/public/cpp/credential_manager_struct_traits.cc

+++ b/components/password_manager/content/public/cpp/credential_manager_struct_traits.cc

@@ -49,7 +49,7 @@ bool EnumTraits<mojom::CredentialType, CredentialType>::FromMojom(

}

// static

-bool StructTraits<mojom::CredentialInfo, CredentialInfo>::Read(

+bool StructTraits<mojom::CredentialInfoDataView, CredentialInfo>::Read(

mojom::CredentialInfoDataView data,

CredentialInfo* out) {

if (data.ReadType(&out->type) && data.ReadId(&out->id) &&