|
|
Move TranslateManager::IsTranslatableURL to be a client-level concept.
The concept of whether a given URL is translatable is an embedder-level one.
This CL does the following:
- Moves TranslateManager::IsTranslatableURL to TranslateService and updates
//chrome callers to call the latter.
- Adds TranslateClient::IsTranslatableURL and has TranslateManager call that.
- Moves TranslateManager unittest (only testing IsTranslatableURL) to be a
unittest on TranslateService.
BUG= 360017
TBR=jochen
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262427
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+58 lines, -92 lines) |
Patch |
 |
M |
chrome/browser/renderer_context_menu/render_view_context_menu.cc
|
View
|
|
2 chunks |
+2 lines, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/translate/translate_manager.h
|
View
|
1
|
1 chunk |
+0 lines, -3 lines |
0 comments
|
Download
|
|
M |
chrome/browser/translate/translate_manager.cc
|
View
|
1
|
3 chunks |
+1 line, -25 lines |
0 comments
|
Download
|
|
M |
chrome/browser/translate/translate_manager_render_view_host_unittest.cc
|
View
|
1
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
|
D |
chrome/browser/translate/translate_manager_unittest.cc
|
View
|
|
1 chunk |
+0 lines, -45 lines |
0 comments
|
Download
|
|
M |
chrome/browser/translate/translate_service.h
|
View
|
|
2 chunks |
+4 lines, -0 lines |
0 comments
|
Download
|
|
M |
chrome/browser/translate/translate_service.cc
|
View
|
|
2 chunks |
+25 lines, -0 lines |
0 comments
|
Download
|
|
A + |
chrome/browser/translate/translate_service_unittest.cc
|
View
|
|
2 chunks |
+11 lines, -14 lines |
0 comments
|
Download
|
|
M |
chrome/browser/translate/translate_tab_helper.h
|
View
|
1
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
|
M |
chrome/browser/translate/translate_tab_helper.cc
|
View
|
1
|
2 chunks |
+5 lines, -0 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/webui/translate_internals/translate_internals_handler.cc
|
View
|
|
2 chunks |
+2 lines, -1 line |
0 comments
|
Download
|
|
M |
chrome/chrome_tests_unit.gypi
|
View
|
1
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
components/translate/core/browser/translate_client.h
|
View
|
1
|
2 chunks |
+4 lines, -0 lines |
0 comments
|
Download
|
Total messages: 8 (0 generated)
|
Chromium Code Reviews
Issue
225263017:
Move TranslateManager::IsTranslatableURL to be a client-level concept. (Closed)
