Move TranslateManager::IsTranslatableURL to be a client-level concept.

chrome/browser/translate/translate_manager.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/translate/translate_manager.h"
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/metrics/field_trial.h"
 #include "base/metrics/histogram.h"
@@ skipping 25 matching lines @@
 #include "components/translate/core/common/translate_pref_names.h"
 #include "components/translate/core/common/translate_switches.h"
 #include "content/public/browser/navigation_controller.h"
 #include "content/public/browser/navigation_entry.h"
 #include "content/public/browser/render_process_host.h"
 #include "content/public/browser/render_view_host.h"
 #include "content/public/browser/web_contents.h"
 #include "net/base/url_util.h"
 #include "net/http/http_status_code.h"
 
-#if defined(OS_CHROMEOS)
-#include "chrome/browser/chromeos/file_manager/app_id.h"
-#include "extensions/common/constants.h"
-#endif
-
 using content::NavigationController;
 using content::NavigationEntry;
 using content::WebContents;
 
 namespace {
 
 // Callbacks for translate errors.
 TranslateManager::TranslateErrorCallbackList* g_callback_list_ = NULL;
 
 const char kReportLanguageDetectionErrorURL[] =
@@ skipping 12 matching lines @@
     return;
 
   g_callback_list_->Notify(details);
 }
 
 }  // namespace
 
 TranslateManager::~TranslateManager() {}
 
 // static
-bool TranslateManager::IsTranslatableURL(const GURL& url) {
-  // A URLs is translatable unless it is one of the following:
-  // - empty (can happen for popups created with window.open(""))
-  // - an internal URL (chrome:// and others)
-  // - the devtools (which is considered UI)
-  // - Chrome OS file manager extension
-  // - an FTP page (as FTP pages tend to have long lists of filenames that may
-  //   confuse the CLD)
-  return !url.is_empty() &&
-         !url.SchemeIs(content::kChromeUIScheme) &&
-         !url.SchemeIs(content::kChromeDevToolsScheme) &&
-#if defined(OS_CHROMEOS)
-         !(url.SchemeIs(extensions::kExtensionScheme) &&
-           url.DomainIs(file_manager::kFileManagerAppId)) &&
-#endif
-         !url.SchemeIs(content::kFtpScheme);
-}
-
-// static
 scoped_ptr<TranslateManager::TranslateErrorCallbackList::Subscription>
 TranslateManager::RegisterTranslateErrorCallback(
     const TranslateManager::TranslateErrorCallback& callback) {
   if (!g_callback_list_)
     g_callback_list_ = new TranslateErrorCallbackList;
   return g_callback_list_->Add(callback);
 }
 
 TranslateManager::TranslateManager(
     TranslateTabHelper* helper,
@@ skipping 39 matching lines @@
   WebContents* web_contents = translate_tab_helper_->GetWebContents();
   if (web_contents->GetContentsMimeType() == "multipart/related") {
     TranslateBrowserMetrics::ReportInitiationStatus(
         TranslateBrowserMetrics::INITIATION_STATUS_MIME_TYPE_IS_NOT_SUPPORTED);
     return;
   }
 
   // Don't translate any Chrome specific page, e.g., New Tab Page, Download,
   // History, and so on.
   GURL page_url = web_contents->GetURL();
-  if (!IsTranslatableURL(page_url)) {
+  if (!translate_client_->IsTranslatableURL(page_url)) {
     TranslateBrowserMetrics::ReportInitiationStatus(
         TranslateBrowserMetrics::INITIATION_STATUS_URL_IS_NOT_SUPPORTED);
     return;
   }
 
   // Get the accepted languages list.
   std::vector<std::string> accept_languages_list;
   base::SplitString(prefs->GetString(accept_languages_pref_name_.c_str()), ',',
                     &accept_languages_list);
 
@@ skipping 261 matching lines @@
                                            &auto_target_lang)) {
     // We need to confirm that the saved target language is still supported.
     // Also, GetLanguageCode will take care of removing country code if any.
     auto_target_lang =
         TranslateDownloadManager::GetLanguageCode(auto_target_lang);
     if (TranslateDownloadManager::IsSupportedLanguage(auto_target_lang))
       return auto_target_lang;
   }
   return std::string();
 }