Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3766)

Unified Diff: chrome/browser/translate/translate_service.cc

Issue 225263017: Move TranslateManager::IsTranslatableURL to be a client-level concept. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/translate/translate_service.cc
diff --git a/chrome/browser/translate/translate_service.cc b/chrome/browser/translate/translate_service.cc
index 4645d108b047042b05c69bfdc123cce6b0259e0a..671dcf1395979436bc78fc5ff8bae2c508dfc544 100644
--- a/chrome/browser/translate/translate_service.cc
+++ b/chrome/browser/translate/translate_service.cc
@@ -13,6 +13,13 @@
#include "chrome/common/chrome_switches.h"
#include "chrome/common/pref_names.h"
#include "components/translate/core/browser/translate_download_manager.h"
+#include "content/public/common/url_constants.h"
+#include "url/gurl.h"
+
+#if defined(OS_CHROMEOS)
+#include "chrome/browser/chromeos/file_manager/app_id.h"
+#include "extensions/common/constants.h"
+#endif
namespace {
// The singleton instance of TranslateService.
@@ -108,3 +115,21 @@ std::string TranslateService::GetTargetLanguage(PrefService* prefs) {
&accept_languages_list);
return TranslateManager::GetTargetLanguage(accept_languages_list);
}
+
+// static
+bool TranslateService::IsTranslatableURL(const GURL& url) {
+ // A URLs is translatable unless it is one of the following:
+ // - empty (can happen for popups created with window.open(""))
+ // - an internal URL (chrome:// and others)
+ // - the devtools (which is considered UI)
+ // - Chrome OS file manager extension
+ // - an FTP page (as FTP pages tend to have long lists of filenames that may
+ // confuse the CLD)
+ return !url.is_empty() && !url.SchemeIs(content::kChromeUIScheme) &&
+ !url.SchemeIs(content::kChromeDevToolsScheme) &&
+#if defined(OS_CHROMEOS)
+ !(url.SchemeIs(extensions::kExtensionScheme) &&
+ url.DomainIs(file_manager::kFileManagerAppId)) &&
+#endif
+ !url.SchemeIs(content::kFtpScheme);
+}
« no previous file with comments | « chrome/browser/translate/translate_service.h ('k') | chrome/browser/translate/translate_service_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698