Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Unified Diff: chrome/browser/translate/translate_service_unittest.cc

Issue 225263017: Move TranslateManager::IsTranslatableURL to be a client-level concept. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/translate/translate_service.cc ('k') | chrome/browser/translate/translate_tab_helper.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/translate/translate_service_unittest.cc
diff --git a/chrome/browser/translate/translate_manager_unittest.cc b/chrome/browser/translate/translate_service_unittest.cc
similarity index 57%
rename from chrome/browser/translate/translate_manager_unittest.cc
rename to chrome/browser/translate/translate_service_unittest.cc
index 5aee9ab8c5a730b6317485ab4d229c5d26ecbb1c..1788072e9c1157654b43f1fa8bd04adab32cd1de 100644
--- a/chrome/browser/translate/translate_manager_unittest.cc
+++ b/chrome/browser/translate/translate_service_unittest.cc
@@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "chrome/browser/translate/translate_manager.h"
+#include "chrome/browser/translate/translate_service.h"
#include "content/public/common/url_constants.h"
#include "testing/gtest/include/gtest/gtest.h"
@@ -13,33 +13,30 @@
#include "extensions/common/constants.h"
#endif
-typedef testing::Test TranslateManagerTest;
-
-TEST_F(TranslateManagerTest, CheckTranslatableURL) {
+TEST(TranslateServiceTest, CheckTranslatableURL) {
GURL empty_url = GURL(std::string());
- EXPECT_FALSE(TranslateManager::IsTranslatableURL(empty_url));
+ EXPECT_FALSE(TranslateService::IsTranslatableURL(empty_url));
std::string chrome = std::string(content::kChromeUIScheme) + "://flags";
GURL chrome_url = GURL(chrome);
- EXPECT_FALSE(TranslateManager::IsTranslatableURL(chrome_url));
+ EXPECT_FALSE(TranslateService::IsTranslatableURL(chrome_url));
std::string devtools = std::string(content::kChromeDevToolsScheme) + "://";
GURL devtools_url = GURL(devtools);
- EXPECT_FALSE(TranslateManager::IsTranslatableURL(devtools_url));
+ EXPECT_FALSE(TranslateService::IsTranslatableURL(devtools_url));
#if defined(OS_CHROMEOS)
- std::string filemanager =
- std::string(extensions::kExtensionScheme) +
- std::string("://") +
- std::string(file_manager::kFileManagerAppId);
+ std::string filemanager = std::string(extensions::kExtensionScheme) +
+ std::string("://") +
+ std::string(file_manager::kFileManagerAppId);
GURL filemanager_url = GURL(filemanager);
- EXPECT_FALSE(TranslateManager::IsTranslatableURL(filemanager_url));
+ EXPECT_FALSE(TranslateService::IsTranslatableURL(filemanager_url));
#endif
std::string ftp = std::string(content::kFtpScheme) + "://google.com/pub";
GURL ftp_url = GURL(ftp);
- EXPECT_FALSE(TranslateManager::IsTranslatableURL(ftp_url));
+ EXPECT_FALSE(TranslateService::IsTranslatableURL(ftp_url));
GURL right_url = GURL("http://www.tamurayukari.com/");
- EXPECT_TRUE(TranslateManager::IsTranslatableURL(right_url));
+ EXPECT_TRUE(TranslateService::IsTranslatableURL(right_url));
}
« no previous file with comments | « chrome/browser/translate/translate_service.cc ('k') | chrome/browser/translate/translate_tab_helper.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698