Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Side by Side Diff: chrome/browser/translate/translate_service_unittest.cc

Issue 225263017: Move TranslateManager::IsTranslatableURL to be a client-level concept. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/translate/translate_manager.h" 5 #include "chrome/browser/translate/translate_service.h"
6 6
7 #include "content/public/common/url_constants.h" 7 #include "content/public/common/url_constants.h"
8 #include "testing/gtest/include/gtest/gtest.h" 8 #include "testing/gtest/include/gtest/gtest.h"
9 #include "url/gurl.h" 9 #include "url/gurl.h"
10 10
11 #if defined(OS_CHROMEOS) 11 #if defined(OS_CHROMEOS)
12 #include "chrome/browser/chromeos/file_manager/app_id.h" 12 #include "chrome/browser/chromeos/file_manager/app_id.h"
13 #include "extensions/common/constants.h" 13 #include "extensions/common/constants.h"
14 #endif 14 #endif
15 15
16 typedef testing::Test TranslateManagerTest; 16 TEST(TranslateServiceTest, CheckTranslatableURL) {
17
18 TEST_F(TranslateManagerTest, CheckTranslatableURL) {
19 GURL empty_url = GURL(std::string()); 17 GURL empty_url = GURL(std::string());
20 EXPECT_FALSE(TranslateManager::IsTranslatableURL(empty_url)); 18 EXPECT_FALSE(TranslateService::IsTranslatableURL(empty_url));
21 19
22 std::string chrome = std::string(content::kChromeUIScheme) + "://flags"; 20 std::string chrome = std::string(content::kChromeUIScheme) + "://flags";
23 GURL chrome_url = GURL(chrome); 21 GURL chrome_url = GURL(chrome);
24 EXPECT_FALSE(TranslateManager::IsTranslatableURL(chrome_url)); 22 EXPECT_FALSE(TranslateService::IsTranslatableURL(chrome_url));
25 23
26 std::string devtools = std::string(content::kChromeDevToolsScheme) + "://"; 24 std::string devtools = std::string(content::kChromeDevToolsScheme) + "://";
27 GURL devtools_url = GURL(devtools); 25 GURL devtools_url = GURL(devtools);
28 EXPECT_FALSE(TranslateManager::IsTranslatableURL(devtools_url)); 26 EXPECT_FALSE(TranslateService::IsTranslatableURL(devtools_url));
29 27
30 #if defined(OS_CHROMEOS) 28 #if defined(OS_CHROMEOS)
31 std::string filemanager = 29 std::string filemanager = std::string(extensions::kExtensionScheme) +
32 std::string(extensions::kExtensionScheme) + 30 std::string("://") +
33 std::string("://") + 31 std::string(file_manager::kFileManagerAppId);
34 std::string(file_manager::kFileManagerAppId);
35 GURL filemanager_url = GURL(filemanager); 32 GURL filemanager_url = GURL(filemanager);
36 EXPECT_FALSE(TranslateManager::IsTranslatableURL(filemanager_url)); 33 EXPECT_FALSE(TranslateService::IsTranslatableURL(filemanager_url));
37 #endif 34 #endif
38 35
39 std::string ftp = std::string(content::kFtpScheme) + "://google.com/pub"; 36 std::string ftp = std::string(content::kFtpScheme) + "://google.com/pub";
40 GURL ftp_url = GURL(ftp); 37 GURL ftp_url = GURL(ftp);
41 EXPECT_FALSE(TranslateManager::IsTranslatableURL(ftp_url)); 38 EXPECT_FALSE(TranslateService::IsTranslatableURL(ftp_url));
42 39
43 GURL right_url = GURL("http://www.tamurayukari.com/"); 40 GURL right_url = GURL("http://www.tamurayukari.com/");
44 EXPECT_TRUE(TranslateManager::IsTranslatableURL(right_url)); 41 EXPECT_TRUE(TranslateService::IsTranslatableURL(right_url));
45 } 42 }
OLDNEW
« no previous file with comments | « chrome/browser/translate/translate_service.cc ('k') | chrome/browser/translate/translate_tab_helper.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698