chrome/browser/ui/webui/translate_internals/translate_internals_handler.cc - Issue 225263017: Move TranslateManager::IsTranslatableURL to be a client-level concept.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/translate_internals/translate_internals_handler.cc

Issue 225263017: Move TranslateManager::IsTranslatableURL to be a client-level concept. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebase Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/webui/translate_internals/translate_internals_handler.cc

diff --git a/chrome/browser/ui/webui/translate_internals/translate_internals_handler.cc b/chrome/browser/ui/webui/translate_internals/translate_internals_handler.cc

index 394162edacce76b928f8f9ff9904a6d6a63f93ae..6603d933e7de93385f2fe55190c46da59a0a33cb 100644

--- a/chrome/browser/ui/webui/translate_internals/translate_internals_handler.cc

+++ b/chrome/browser/ui/webui/translate_internals/translate_internals_handler.cc

@@ -13,6 +13,7 @@

#include "base/values.h"

#include "chrome/browser/chrome_notification_types.h"

#include "chrome/browser/profiles/profile.h"

+#include "chrome/browser/translate/translate_service.h"

#include "chrome/browser/translate/translate_tab_helper.h"

#include "chrome/common/pref_names.h"

#include "components/translate/core/browser/translate_download_manager.h"

@@ -71,7 +72,7 @@ void TranslateInternalsHandler::Observe(

content::Source<content::WebContents>(source).ptr();

if (web_contents->GetBrowserContext()->IsOffTheRecord() ||

- !TranslateManager::IsTranslatableURL(language_detection_details->url)) {

+ !TranslateService::IsTranslatableURL(language_detection_details->url)) {

return;

}

« no previous file with comments | « chrome/browser/translate/translate_tab_helper.cc ('k') | chrome/chrome_tests_unit.gypi » ('j') | no next file with comments »