Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(461)

Issue 2243783002: Call IsStringLiteral instead of IsPropertyName in VisitObjectLiteral. (Closed)

Created:
4 years, 4 months ago by rmcilroy
Modified:
4 years, 4 months ago
Reviewers:
epertoso, Toon Verwaest
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, rmcilroy, v8-ppc-ports_googlegroups.com, oth
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Call IsStringLiteral instead of IsPropertyName in VisitObjectLiteral. This should be faster and should give the same result. BUG=v8:5203 Committed: https://crrev.com/cc7587110eaaa66ae37b7a870fd53d720fd9b003 Cr-Commit-Position: refs/heads/master@{#38616}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -15 lines) Patch
M src/ast/ast.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M src/compiler/ast-graph-builder.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/crankshaft/hydrogen.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/full-codegen/arm/full-codegen-arm.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/full-codegen/ppc/full-codegen-ppc.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/full-codegen/s390/full-codegen-s390.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/full-codegen/x87/full-codegen-x87.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/interpreter/bytecode-generator.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
rmcilroy
epertoso@chromium.org: Please review changes in compiler/ verwaest@chromium.org: Please review changes everywhere else. Thanks.
4 years, 4 months ago (2016-08-12 10:12:09 UTC) #2
Toon Verwaest
lgtm
4 years, 4 months ago (2016-08-12 10:52:41 UTC) #3
epertoso
lgtm for changes in compiler/
4 years, 4 months ago (2016-08-12 10:54:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2243783002/1
4 years, 4 months ago (2016-08-12 12:11:22 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-12 12:34:07 UTC) #7
commit-bot: I haz the power
4 years, 4 months ago (2016-08-12 12:34:35 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cc7587110eaaa66ae37b7a870fd53d720fd9b003
Cr-Commit-Position: refs/heads/master@{#38616}

Powered by Google App Engine
This is Rietveld 408576698