Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Side by Side Diff: src/full-codegen/mips64/full-codegen-mips64.cc

Issue 2243783002: Call IsStringLiteral instead of IsPropertyName in VisitObjectLiteral. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/full-codegen/mips/full-codegen-mips.cc ('k') | src/full-codegen/ppc/full-codegen-ppc.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_MIPS64 5 #if V8_TARGET_ARCH_MIPS64
6 6
7 // Note on Mips implementation: 7 // Note on Mips implementation:
8 // 8 //
9 // The result_register() for mips is the 'v0' register, which is defined 9 // The result_register() for mips is the 'v0' register, which is defined
10 // by the ABI to contain function return values. However, the first 10 // by the ABI to contain function return values. However, the first
(...skipping 1406 matching lines...) Expand 10 before | Expand all | Expand 10 after
1417 } 1417 }
1418 switch (property->kind()) { 1418 switch (property->kind()) {
1419 case ObjectLiteral::Property::CONSTANT: 1419 case ObjectLiteral::Property::CONSTANT:
1420 UNREACHABLE(); 1420 UNREACHABLE();
1421 case ObjectLiteral::Property::MATERIALIZED_LITERAL: 1421 case ObjectLiteral::Property::MATERIALIZED_LITERAL:
1422 DCHECK(!CompileTimeValue::IsCompileTimeValue(property->value())); 1422 DCHECK(!CompileTimeValue::IsCompileTimeValue(property->value()));
1423 // Fall through. 1423 // Fall through.
1424 case ObjectLiteral::Property::COMPUTED: 1424 case ObjectLiteral::Property::COMPUTED:
1425 // It is safe to use [[Put]] here because the boilerplate already 1425 // It is safe to use [[Put]] here because the boilerplate already
1426 // contains computed properties with an uninitialized value. 1426 // contains computed properties with an uninitialized value.
1427 if (key->IsPropertyName()) { 1427 if (key->IsStringLiteral()) {
1428 DCHECK(key->IsPropertyName());
1428 if (property->emit_store()) { 1429 if (property->emit_store()) {
1429 VisitForAccumulatorValue(value); 1430 VisitForAccumulatorValue(value);
1430 __ mov(StoreDescriptor::ValueRegister(), result_register()); 1431 __ mov(StoreDescriptor::ValueRegister(), result_register());
1431 DCHECK(StoreDescriptor::ValueRegister().is(a0)); 1432 DCHECK(StoreDescriptor::ValueRegister().is(a0));
1432 __ li(StoreDescriptor::NameRegister(), Operand(key->value())); 1433 __ li(StoreDescriptor::NameRegister(), Operand(key->value()));
1433 __ ld(StoreDescriptor::ReceiverRegister(), MemOperand(sp)); 1434 __ ld(StoreDescriptor::ReceiverRegister(), MemOperand(sp));
1434 EmitLoadStoreICSlot(property->GetSlot(0)); 1435 EmitLoadStoreICSlot(property->GetSlot(0));
1435 CallStoreIC(); 1436 CallStoreIC();
1436 PrepareForBailoutForId(key->id(), BailoutState::NO_REGISTERS); 1437 PrepareForBailoutForId(key->id(), BailoutState::NO_REGISTERS);
1437 1438
(...skipping 2348 matching lines...) Expand 10 before | Expand all | Expand 10 after
3786 reinterpret_cast<uint64_t>( 3787 reinterpret_cast<uint64_t>(
3787 isolate->builtins()->OnStackReplacement()->entry())); 3788 isolate->builtins()->OnStackReplacement()->entry()));
3788 return ON_STACK_REPLACEMENT; 3789 return ON_STACK_REPLACEMENT;
3789 } 3790 }
3790 3791
3791 3792
3792 } // namespace internal 3793 } // namespace internal
3793 } // namespace v8 3794 } // namespace v8
3794 3795
3795 #endif // V8_TARGET_ARCH_MIPS64 3796 #endif // V8_TARGET_ARCH_MIPS64
OLDNEW
« no previous file with comments | « src/full-codegen/mips/full-codegen-mips.cc ('k') | src/full-codegen/ppc/full-codegen-ppc.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698