Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1044)

Side by Side Diff: src/full-codegen/arm64/full-codegen-arm64.cc

Issue 2243783002: Call IsStringLiteral instead of IsPropertyName in VisitObjectLiteral. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/full-codegen/arm/full-codegen-arm.cc ('k') | src/full-codegen/ia32/full-codegen-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_ARM64 5 #if V8_TARGET_ARCH_ARM64
6 6
7 #include "src/ast/scopes.h" 7 #include "src/ast/scopes.h"
8 #include "src/code-factory.h" 8 #include "src/code-factory.h"
9 #include "src/code-stubs.h" 9 #include "src/code-stubs.h"
10 #include "src/codegen.h" 10 #include "src/codegen.h"
(...skipping 1394 matching lines...) Expand 10 before | Expand all | Expand 10 after
1405 } 1405 }
1406 switch (property->kind()) { 1406 switch (property->kind()) {
1407 case ObjectLiteral::Property::CONSTANT: 1407 case ObjectLiteral::Property::CONSTANT:
1408 UNREACHABLE(); 1408 UNREACHABLE();
1409 case ObjectLiteral::Property::MATERIALIZED_LITERAL: 1409 case ObjectLiteral::Property::MATERIALIZED_LITERAL:
1410 DCHECK(!CompileTimeValue::IsCompileTimeValue(property->value())); 1410 DCHECK(!CompileTimeValue::IsCompileTimeValue(property->value()));
1411 // Fall through. 1411 // Fall through.
1412 case ObjectLiteral::Property::COMPUTED: 1412 case ObjectLiteral::Property::COMPUTED:
1413 // It is safe to use [[Put]] here because the boilerplate already 1413 // It is safe to use [[Put]] here because the boilerplate already
1414 // contains computed properties with an uninitialized value. 1414 // contains computed properties with an uninitialized value.
1415 if (key->IsPropertyName()) { 1415 if (key->IsStringLiteral()) {
1416 DCHECK(key->IsPropertyName());
1416 if (property->emit_store()) { 1417 if (property->emit_store()) {
1417 VisitForAccumulatorValue(value); 1418 VisitForAccumulatorValue(value);
1418 DCHECK(StoreDescriptor::ValueRegister().is(x0)); 1419 DCHECK(StoreDescriptor::ValueRegister().is(x0));
1419 __ Mov(StoreDescriptor::NameRegister(), Operand(key->value())); 1420 __ Mov(StoreDescriptor::NameRegister(), Operand(key->value()));
1420 __ Peek(StoreDescriptor::ReceiverRegister(), 0); 1421 __ Peek(StoreDescriptor::ReceiverRegister(), 0);
1421 EmitLoadStoreICSlot(property->GetSlot(0)); 1422 EmitLoadStoreICSlot(property->GetSlot(0));
1422 CallStoreIC(); 1423 CallStoreIC();
1423 PrepareForBailoutForId(key->id(), BailoutState::NO_REGISTERS); 1424 PrepareForBailoutForId(key->id(), BailoutState::NO_REGISTERS);
1424 1425
1425 if (NeedsHomeObject(value)) { 1426 if (NeedsHomeObject(value)) {
(...skipping 2420 matching lines...) Expand 10 before | Expand all | Expand 10 after
3846 } 3847 }
3847 3848
3848 return INTERRUPT; 3849 return INTERRUPT;
3849 } 3850 }
3850 3851
3851 3852
3852 } // namespace internal 3853 } // namespace internal
3853 } // namespace v8 3854 } // namespace v8
3854 3855
3855 #endif // V8_TARGET_ARCH_ARM64 3856 #endif // V8_TARGET_ARCH_ARM64
OLDNEW
« no previous file with comments | « src/full-codegen/arm/full-codegen-arm.cc ('k') | src/full-codegen/ia32/full-codegen-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698