Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Side by Side Diff: src/full-codegen/ppc/full-codegen-ppc.cc

Issue 2243783002: Call IsStringLiteral instead of IsPropertyName in VisitObjectLiteral. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_PPC 5 #if V8_TARGET_ARCH_PPC
6 6
7 #include "src/ast/scopes.h" 7 #include "src/ast/scopes.h"
8 #include "src/code-factory.h" 8 #include "src/code-factory.h"
9 #include "src/code-stubs.h" 9 #include "src/code-stubs.h"
10 #include "src/codegen.h" 10 #include "src/codegen.h"
(...skipping 1374 matching lines...) Expand 10 before | Expand all | Expand 10 after
1385 } 1385 }
1386 switch (property->kind()) { 1386 switch (property->kind()) {
1387 case ObjectLiteral::Property::CONSTANT: 1387 case ObjectLiteral::Property::CONSTANT:
1388 UNREACHABLE(); 1388 UNREACHABLE();
1389 case ObjectLiteral::Property::MATERIALIZED_LITERAL: 1389 case ObjectLiteral::Property::MATERIALIZED_LITERAL:
1390 DCHECK(!CompileTimeValue::IsCompileTimeValue(property->value())); 1390 DCHECK(!CompileTimeValue::IsCompileTimeValue(property->value()));
1391 // Fall through. 1391 // Fall through.
1392 case ObjectLiteral::Property::COMPUTED: 1392 case ObjectLiteral::Property::COMPUTED:
1393 // It is safe to use [[Put]] here because the boilerplate already 1393 // It is safe to use [[Put]] here because the boilerplate already
1394 // contains computed properties with an uninitialized value. 1394 // contains computed properties with an uninitialized value.
1395 if (key->IsPropertyName()) { 1395 if (key->IsStringLiteral()) {
1396 DCHECK(key->IsPropertyName());
1396 if (property->emit_store()) { 1397 if (property->emit_store()) {
1397 VisitForAccumulatorValue(value); 1398 VisitForAccumulatorValue(value);
1398 DCHECK(StoreDescriptor::ValueRegister().is(r3)); 1399 DCHECK(StoreDescriptor::ValueRegister().is(r3));
1399 __ mov(StoreDescriptor::NameRegister(), Operand(key->value())); 1400 __ mov(StoreDescriptor::NameRegister(), Operand(key->value()));
1400 __ LoadP(StoreDescriptor::ReceiverRegister(), MemOperand(sp)); 1401 __ LoadP(StoreDescriptor::ReceiverRegister(), MemOperand(sp));
1401 EmitLoadStoreICSlot(property->GetSlot(0)); 1402 EmitLoadStoreICSlot(property->GetSlot(0));
1402 CallStoreIC(); 1403 CallStoreIC();
1403 PrepareForBailoutForId(key->id(), BailoutState::NO_REGISTERS); 1404 PrepareForBailoutForId(key->id(), BailoutState::NO_REGISTERS);
1404 1405
1405 if (NeedsHomeObject(value)) { 1406 if (NeedsHomeObject(value)) {
(...skipping 2354 matching lines...) Expand 10 before | Expand all | Expand 10 after
3760 3761
3761 DCHECK(Assembler::IsCrSet(Assembler::instr_at(cmp_address))); 3762 DCHECK(Assembler::IsCrSet(Assembler::instr_at(cmp_address)));
3762 3763
3763 DCHECK(interrupt_address == 3764 DCHECK(interrupt_address ==
3764 isolate->builtins()->OnStackReplacement()->entry()); 3765 isolate->builtins()->OnStackReplacement()->entry());
3765 return ON_STACK_REPLACEMENT; 3766 return ON_STACK_REPLACEMENT;
3766 } 3767 }
3767 } // namespace internal 3768 } // namespace internal
3768 } // namespace v8 3769 } // namespace v8
3769 #endif // V8_TARGET_ARCH_PPC 3770 #endif // V8_TARGET_ARCH_PPC
OLDNEW
« no previous file with comments | « src/full-codegen/mips64/full-codegen-mips64.cc ('k') | src/full-codegen/s390/full-codegen-s390.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698