Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Side by Side Diff: src/full-codegen/ia32/full-codegen-ia32.cc

Issue 2243783002: Call IsStringLiteral instead of IsPropertyName in VisitObjectLiteral. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_IA32 5 #if V8_TARGET_ARCH_IA32
6 6
7 #include "src/ast/scopes.h" 7 #include "src/ast/scopes.h"
8 #include "src/code-factory.h" 8 #include "src/code-factory.h"
9 #include "src/code-stubs.h" 9 #include "src/code-stubs.h"
10 #include "src/codegen.h" 10 #include "src/codegen.h"
(...skipping 1337 matching lines...) Expand 10 before | Expand all | Expand 10 after
1348 } 1348 }
1349 switch (property->kind()) { 1349 switch (property->kind()) {
1350 case ObjectLiteral::Property::CONSTANT: 1350 case ObjectLiteral::Property::CONSTANT:
1351 UNREACHABLE(); 1351 UNREACHABLE();
1352 case ObjectLiteral::Property::MATERIALIZED_LITERAL: 1352 case ObjectLiteral::Property::MATERIALIZED_LITERAL:
1353 DCHECK(!CompileTimeValue::IsCompileTimeValue(value)); 1353 DCHECK(!CompileTimeValue::IsCompileTimeValue(value));
1354 // Fall through. 1354 // Fall through.
1355 case ObjectLiteral::Property::COMPUTED: 1355 case ObjectLiteral::Property::COMPUTED:
1356 // It is safe to use [[Put]] here because the boilerplate already 1356 // It is safe to use [[Put]] here because the boilerplate already
1357 // contains computed properties with an uninitialized value. 1357 // contains computed properties with an uninitialized value.
1358 if (key->IsPropertyName()) { 1358 if (key->IsStringLiteral()) {
1359 DCHECK(key->IsPropertyName());
1359 if (property->emit_store()) { 1360 if (property->emit_store()) {
1360 VisitForAccumulatorValue(value); 1361 VisitForAccumulatorValue(value);
1361 DCHECK(StoreDescriptor::ValueRegister().is(eax)); 1362 DCHECK(StoreDescriptor::ValueRegister().is(eax));
1362 __ mov(StoreDescriptor::NameRegister(), Immediate(key->value())); 1363 __ mov(StoreDescriptor::NameRegister(), Immediate(key->value()));
1363 __ mov(StoreDescriptor::ReceiverRegister(), Operand(esp, 0)); 1364 __ mov(StoreDescriptor::ReceiverRegister(), Operand(esp, 0));
1364 EmitLoadStoreICSlot(property->GetSlot(0)); 1365 EmitLoadStoreICSlot(property->GetSlot(0));
1365 CallStoreIC(); 1366 CallStoreIC();
1366 PrepareForBailoutForId(key->id(), BailoutState::NO_REGISTERS); 1367 PrepareForBailoutForId(key->id(), BailoutState::NO_REGISTERS);
1367 if (NeedsHomeObject(value)) { 1368 if (NeedsHomeObject(value)) {
1368 EmitSetHomeObjectAccumulator(value, 0, property->GetSlot(1)); 1369 EmitSetHomeObjectAccumulator(value, 0, property->GetSlot(1));
(...skipping 2302 matching lines...) Expand 10 before | Expand all | Expand 10 after
3671 isolate->builtins()->OnStackReplacement()->entry(), 3672 isolate->builtins()->OnStackReplacement()->entry(),
3672 Assembler::target_address_at(call_target_address, unoptimized_code)); 3673 Assembler::target_address_at(call_target_address, unoptimized_code));
3673 return ON_STACK_REPLACEMENT; 3674 return ON_STACK_REPLACEMENT;
3674 } 3675 }
3675 3676
3676 3677
3677 } // namespace internal 3678 } // namespace internal
3678 } // namespace v8 3679 } // namespace v8
3679 3680
3680 #endif // V8_TARGET_ARCH_IA32 3681 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/full-codegen/arm64/full-codegen-arm64.cc ('k') | src/full-codegen/mips/full-codegen-mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698