Update Crashpad to 56b14bceefcec03fc11b3222c435522922f65640

Update Crashpad to 56b14bceefcec03fc11b3222c435522922f65640

c281e30f931a mac: Update the dyld_all_image_infos structure for 10.12
6dbf9526782d mac: Interpret the size returned by _NSGetExecutablePath()
             correctly
89835b30f8e6 posix: Correctly show the expected exit status in
             multiprocess tests
3887d99e4801 mac: Handle EXC_RESOURCE RESOURCE_TYPE_IO
335ef494677f mac: dyld fatal errors appear as exit(1) on 10.12
7b8de8a40474 Adapt dyld_images.proctype to running changes in 10.12
7c807242e0b1 mac: dyld fatal errors appear as abort() on 10.12
6f6242865d85 win: Handle the case when GetBytesBuffer returns error in
             HTTPTransportWin
26c9d3fa6d9b Update mini_chromium to 9c5463b4d4b3
18a839c81000 Update GYP to 93cc6e2c23e4
56b14bceefce win getopt: memcmp() -> strncmp() for ASan

BUG=635990
Committed: https://crrev.com/6b8d382bcb17358f00a8fd0142e5074393a7c049
Cr-Commit-Position: refs/heads/master@{#411261}

[scottmg, 2016-08-10 22:24:15]

The CQ bit was checked by scottmg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-10 22:25:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[scottmg, 2016-08-10 22:27:54]

scottmg@chromium.org changed reviewers:
+ mark@chromium.org

[scottmg, 2016-08-10 22:29:34]

https://codereview.chromium.org/2236493004/diff/1/third_party/crashpad/crashp...
File
third_party/crashpad/crashpad/snapshot/mac/mach_o_image_annotations_reader_test.cc
(right):

https://codereview.chromium.org/2236493004/diff/1/third_party/crashpad/crashp...
third_party/crashpad/crashpad/snapshot/mac/mach_o_image_annotations_reader_test.cc:289:
// Prior to 10.12, dyld fatal errors result in the execution of an
Tabs we should fix upstream.

[Mark Mentovai, 2016-08-10 23:39:27]

LGTM

https://codereview.chromium.org/2236493004/diff/1/third_party/crashpad/crashp...
File
third_party/crashpad/crashpad/snapshot/mac/mach_o_image_annotations_reader_test.cc
(right):

https://codereview.chromium.org/2236493004/diff/1/third_party/crashpad/crashp...
third_party/crashpad/crashpad/snapshot/mac/mach_o_image_annotations_reader_test.cc:289:
// Prior to 10.12, dyld fatal errors result in the execution of an
On 2016/08/10 22:29:34, scottmg wrote:
> Tabs we should fix upstream.

Guess PolyGerrit didn't highlight those. :(

[scottmg, 2016-08-10 23:41:25]

On 2016/08/10 23:39:27, Mark Mentovai wrote:
> LGTM
> 
>
https://codereview.chromium.org/2236493004/diff/1/third_party/crashpad/crashp...
> File
>
third_party/crashpad/crashpad/snapshot/mac/mach_o_image_annotations_reader_test.cc
> (right):
> 
>
https://codereview.chromium.org/2236493004/diff/1/third_party/crashpad/crashp...
>
third_party/crashpad/crashpad/snapshot/mac/mach_o_image_annotations_reader_test.cc:289:
> // Prior to 10.12, dyld fatal errors result in the execution of an
> On 2016/08/10 22:29:34, scottmg wrote:
> > Tabs we should fix upstream.
> 
> Guess PolyGerrit didn't highlight those. :(

Is that bug #7 of the day? :)

[scottmg, 2016-08-10 23:42:22]

The CQ bit was unchecked by scottmg@chromium.org

[scottmg, 2016-08-10 23:42:28]

The CQ bit was checked by scottmg@chromium.org

[commit-bot: I haz the power, 2016-08-10 23:43:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Mark Mentovai, 2016-08-10 23:48:33]

On 2016/08/10 23:41:25, scottmg wrote:
> On 2016/08/10 23:39:27, Mark Mentovai wrote:
> > LGTM
> > 
> >
>
https://codereview.chromium.org/2236493004/diff/1/third_party/crashpad/crashp...
> > File
> >
>
third_party/crashpad/crashpad/snapshot/mac/mach_o_image_annotations_reader_test.cc
> > (right):
> > 
> >
>
https://codereview.chromium.org/2236493004/diff/1/third_party/crashpad/crashp...
> >
>
third_party/crashpad/crashpad/snapshot/mac/mach_o_image_annotations_reader_test.cc:289:
> > // Prior to 10.12, dyld fatal errors result in the execution of an
> > On 2016/08/10 22:29:34, scottmg wrote:
> > > Tabs we should fix upstream.
> > 
> > Guess PolyGerrit didn't highlight those. :(
> 
> Is that bug #7 of the day? :)

Yeah, I think so. Not their best day. :(

[Mark Mentovai, 2016-08-10 23:52:10]

On 2016/08/10 23:48:33, Mark Mentovai wrote:
> On 2016/08/10 23:41:25, scottmg wrote:
> > On 2016/08/10 23:39:27, Mark Mentovai wrote:
> > > LGTM
> > > 
> > >
> >
>
https://codereview.chromium.org/2236493004/diff/1/third_party/crashpad/crashp...
> > > File
> > >
> >
>
third_party/crashpad/crashpad/snapshot/mac/mach_o_image_annotations_reader_test.cc
> > > (right):
> > > 
> > >
> >
>
https://codereview.chromium.org/2236493004/diff/1/third_party/crashpad/crashp...
> > >
> >
>
third_party/crashpad/crashpad/snapshot/mac/mach_o_image_annotations_reader_test.cc:289:
> > > // Prior to 10.12, dyld fatal errors result in the execution of an
> > > On 2016/08/10 22:29:34, scottmg wrote:
> > > > Tabs we should fix upstream.
> > > 
> > > Guess PolyGerrit didn't highlight those. :(
> > 
> > Is that bug #7 of the day? :)
> 
> Yeah, I think so. Not their best day. :(

It actually did, or at least it does today.

https://chromium-review.googlesource.com/c/365920/3/snapshot/mac/mach_o_image...

Maybe we're the ones who suck after all.

[commit-bot: I haz the power, 2016-08-11 02:49:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-11 02:49:01]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[scottmg, 2016-08-11 03:08:48]

The CQ bit was checked by scottmg@chromium.org

[commit-bot: I haz the power, 2016-08-11 03:09:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-11 04:09:33]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-08-11 04:12:12]

Description was changed from

==========
Update Crashpad to 56b14bceefcec03fc11b3222c435522922f65640

c281e30f931a mac: Update the dyld_all_image_infos structure for 10.12
6dbf9526782d mac: Interpret the size returned by _NSGetExecutablePath()
             correctly
89835b30f8e6 posix: Correctly show the expected exit status in
             multiprocess tests
3887d99e4801 mac: Handle EXC_RESOURCE RESOURCE_TYPE_IO
335ef494677f mac: dyld fatal errors appear as exit(1) on 10.12
7b8de8a40474 Adapt dyld_images.proctype to running changes in 10.12
7c807242e0b1 mac: dyld fatal errors appear as abort() on 10.12
6f6242865d85 win: Handle the case when GetBytesBuffer returns error in
             HTTPTransportWin
26c9d3fa6d9b Update mini_chromium to 9c5463b4d4b3
18a839c81000 Update GYP to 93cc6e2c23e4
56b14bceefce win getopt: memcmp() -> strncmp() for ASan

BUG=635990
==========

to

==========
Update Crashpad to 56b14bceefcec03fc11b3222c435522922f65640

c281e30f931a mac: Update the dyld_all_image_infos structure for 10.12
6dbf9526782d mac: Interpret the size returned by _NSGetExecutablePath()
             correctly
89835b30f8e6 posix: Correctly show the expected exit status in
             multiprocess tests
3887d99e4801 mac: Handle EXC_RESOURCE RESOURCE_TYPE_IO
335ef494677f mac: dyld fatal errors appear as exit(1) on 10.12
7b8de8a40474 Adapt dyld_images.proctype to running changes in 10.12
7c807242e0b1 mac: dyld fatal errors appear as abort() on 10.12
6f6242865d85 win: Handle the case when GetBytesBuffer returns error in
             HTTPTransportWin
26c9d3fa6d9b Update mini_chromium to 9c5463b4d4b3
18a839c81000 Update GYP to 93cc6e2c23e4
56b14bceefce win getopt: memcmp() -> strncmp() for ASan

BUG=635990

Committed: https://crrev.com/6b8d382bcb17358f00a8fd0142e5074393a7c049
Cr-Commit-Position: refs/heads/master@{#411261}
==========

[commit-bot: I haz the power, 2016-08-11 04:12:14]

Patchset 1 (id:??) landed as
https://crrev.com/6b8d382bcb17358f00a8fd0142e5074393a7c049
Cr-Commit-Position: refs/heads/master@{#411261}