third_party/crashpad/crashpad/third_party/getopt/getopt.cc - Issue 2236493004: Update Crashpad to 56b14bceefcec03fc11b3222c435522922f65640

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/crashpad/crashpad/third_party/getopt/getopt.cc

Issue 2236493004: Update Crashpad to 56b14bceefcec03fc11b3222c435522922f65640 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/crashpad/crashpad/snapshot/mac/mach_o_image_annotations_reader_test.cc ('K') | « third_party/crashpad/crashpad/third_party/getopt/README.crashpad ('k') | third_party/crashpad/crashpad/util/mach/exception_types.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/crashpad/crashpad/third_party/getopt/getopt.cc

diff --git a/third_party/crashpad/crashpad/third_party/getopt/getopt.cc b/third_party/crashpad/crashpad/third_party/getopt/getopt.cc

index 1f6eaffdb842111d3bc709e476e3421c01322790..137218b999acb858e411a9859f7f3e3f62feb574 100644

--- a/third_party/crashpad/crashpad/third_party/getopt/getopt.cc

+++ b/third_party/crashpad/crashpad/third_party/getopt/getopt.cc

@@ -240,11 +240,11 @@ getopt_internal (int argc, char **argv, char *shortopts,

/* first, is it a long option? */

if (longopts != NULL

- && (memcmp (argv[optind], "--", 2) == 0

+ && (strncmp (argv[optind], "--", 2) == 0

|| (only && argv[optind][0] == '+')) && optwhere == 1)

{

/* handle long options */

- if (memcmp (argv[optind], "--", 2) == 0)

+ if (strncmp (argv[optind], "--", 2) == 0)

optwhere = 2;

longopt_match = -1;

possible_arg = strchr (argv[optind] + optwhere, '=');

@@ -259,8 +259,8 @@ getopt_internal (int argc, char **argv, char *shortopts,

match_chars = (possible_arg - argv[optind]) - optwhere;

for (optindex = 0; longopts[optindex].name != NULL; optindex++)

{

- if (memcmp (argv[optind] + optwhere,

- longopts[optindex].name, match_chars) == 0)

+ if (strncmp (argv[optind] + optwhere,

+ longopts[optindex].name, match_chars) == 0)

{

/* do we have an exact match? */

if (match_chars == strlen (longopts[optindex].name))