third_party/crashpad/crashpad/util/mach/exception_types.cc - Issue 2236493004: Update Crashpad to 56b14bceefcec03fc11b3222c435522922f65640

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/crashpad/crashpad/util/mach/exception_types.cc

Issue 2236493004: Update Crashpad to 56b14bceefcec03fc11b3222c435522922f65640 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/crashpad/crashpad/snapshot/mac/mach_o_image_annotations_reader_test.cc ('K') | « third_party/crashpad/crashpad/third_party/getopt/getopt.cc ('k') | third_party/crashpad/crashpad/util/net/http_transport_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/crashpad/crashpad/util/mach/exception_types.cc

diff --git a/third_party/crashpad/crashpad/util/mach/exception_types.cc b/third_party/crashpad/crashpad/util/mach/exception_types.cc

index 0199b3145a7cd1d6e3823860136ebe98b28a5d0e..cef90f9a61aa7b93b213bb72ad6732e91dcab170 100644

--- a/third_party/crashpad/crashpad/util/mach/exception_types.cc

+++ b/third_party/crashpad/crashpad/util/mach/exception_types.cc

@@ -201,6 +201,12 @@ bool IsExceptionNonfatalResource(exception_type_t exception,

return true;

}

+ if (resource_type == RESOURCE_TYPE_IO) {

+ // These exceptions don’t ever appear to be fatal. See

+ // https://crashpad.chromium.org/bug/124.

+ return true;

+ }

// Treat unknown exceptions as fatal. This is the conservative approach: it

// may result in more crash reports being generated, but the type-flavor

// combinations can be evaluated to determine appropriate handling.